Use wordpress i 18 n in all of our codebase [MAILPOET-4908] #4627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samnajian
force-pushed
the
MAILPOET-4908-use-wordpress-i-18-n-in-all-of-our-codebase
branch
9 times, most recently
from
dd2eea7
to
4ff83a3
Compare
samnajian
force-pushed
the
MAILPOET-4908-use-wordpress-i-18-n-in-all-of-our-codebase
branch
from
4ff83a3
to
5845d5c
Compare
samnajian
force-pushed
the
MAILPOET-4908-use-wordpress-i-18-n-in-all-of-our-codebase
branch
6 times, most recently
from
419d2ac
to
422ae5a
Compare
samnajian
force-pushed
the
MAILPOET-4908-use-wordpress-i-18-n-in-all-of-our-codebase
branch
from
422ae5a
to
7f3b71b
Compare
samnajian
changed the title
samnajian
force-pushed
the
MAILPOET-4908-use-wordpress-i-18-n-in-all-of-our-codebase
branch
11 times, most recently
from
db2d95e
to
aea5c60
Compare
[MAILPOET-4908]
[MAILPOET-4908]
[MAILPOET-4908]
[MAILPOET-4908]
[MAILPOET-4908]
[MAILPOET-4908]
[MAILPOET-4908]
[MAILPOET-4908]
As per import of @wordpress/i18n, and since it's using lodash We'll need to reset window._ to underscore where we have a hard dependency to underscore [MAILPOET-4908]
[MAILPOET-4908]
This should fix the flakiness of EditorCouponCest::addCoupon [MAILPOET-4908]
[MAILPOET-4908]
[MAILPOET-4908]
[MAILPOET-4908]
[MAILPOET-4908]
[MAILPOET-4908]
Some part of code had been removed by mistake for solving merge conflicts [MAILPOET-4908]
[MAILPOET-4908]
[MAILPOET-4908]
[MAILPOET-4908]
[MAILPOET-4908]
[MAILPOET-4908]
samnajian
force-pushed
the
MAILPOET-4908-use-wordpress-i-18-n-in-all-of-our-codebase
branch
from
028d1cc
to
13a8587
Compare
Aschepikov
deleted the
MAILPOET-4908-use-wordpress-i-18-n-in-all-of-our-codebase
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR uses @wordpress/i18n package in the js/ts code related to Newsletters and the common code ( the directory mailpoet/assets/js/src/common ).
Code review notes
There will be a follow up ticket to take care of rest of the codebase.
QA notes
Please switch your site's language to a language that has a good coverage and check if the plugin remains translated on different pages
Linked tickets
MAILPOET-4908
After-merge notes
Please run the following commands to keep the translations current for the release to work fine:
./do translations:build./do translations:push./do release:version-get-nextto get the next version to use in the next step./do translations:prepare-language-packs {version from previous step}