Remove fix for lodash/underscore conflict [MAILPOET-5127] #4844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull reviewers statsStats of the last 90 days for mailpoet:
|
lysyjan
deleted the
MAILPOET-5127-remove-the-workaround-for-lodash-underscore-conflict
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the workaround added for lodash/underscore conflict since the newer versions of
@wordpress/i18nare not using lodash anymore.Also Underscore is needed on the window object in newsletter editor, because how internally it’s used by Backbone/Marionette so this line was not removed.
QA notes
No QA is needed if tests pass on the CI.
Linked PRs
Use wordpress i 18 n in all of our codebase
Linked tickets
MAILPOET-5127