Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use wordpress i 18 n in all of our codebase [MAILPOET-4908] #4627

Merged
merged 32 commits into from
Mar 20, 2023
Merged

Use wordpress i 18 n in all of our codebase [MAILPOET-4908] #4627

merged 32 commits into from
Mar 20, 2023

Commits on Mar 16, 2023

  1. Add newsletter_editor.js using AssetsController 

    newsletter_editor.js was added via newsletter/editor.html
it's now removed from the template and wpEnqueueScript is
user instead

[MAILPOET-4908]
    @samnajian
    samnajian committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    3c618ed View commit details
    Browse the repository at this point in the history

  2. Fix memory issue when building translations 

    [MAILPOET-4908]
    @samnajian
    samnajian committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    db9107b View commit details
    Browse the repository at this point in the history

  3. Remove editor translations from tpl and add via wp/i18n 

    [MAILPOET-4908]
    @samnajian
    samnajian committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    cfc8ba6 View commit details
    Browse the repository at this point in the history

  4. Use translator from @wordpress/i18n in newsletter app 

    [MAILPOET-4908]
    @samnajian
    samnajian committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    3ed3d8b View commit details
    Browse the repository at this point in the history

  5. Use wp/i18n in components that's used for newsletter app 

    [MAILPOET-4908]
    @samnajian
    samnajian committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    7b62b14 View commit details
    Browse the repository at this point in the history

  6. Unify wording that was causing tests to fail 

    Test were sometimes using `Delete permanently` and sometimes
`Delete Permanently` with capital P, causing some to fail

[MAILPOET-4908]
    @samnajian
    samnajian committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    a03157a View commit details
    Browse the repository at this point in the history

  7. Move code around to make registerTranslations accesable 

    [MAILPOET-4908]
    @samnajian
    samnajian committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    9939e71 View commit details
    Browse the repository at this point in the history

  8. Make sure translations are loaded for newsletter editor 

    [MAILPOET-4908]
    @samnajian
    samnajian committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    be7db66 View commit details
    Browse the repository at this point in the history

  9. Fix issue causing newsletter tests to fail 

    Accessing wp from global scope was making the tests fail

[MAILPOET-4908]
    @samnajian
    samnajian committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    23d28e4 View commit details
    Browse the repository at this point in the history

  10. Translate some more common strings using wp/i18n 

    [MAILPOET-4908]
    @samnajian
    samnajian committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    6c7ce79 View commit details
    Browse the repository at this point in the history

  11. Enqueue newletter assest using asset controller 

    [MAILPOET-4908]
    @samnajian
    samnajian committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    dd591bd View commit details
    Browse the repository at this point in the history

  12. Add admin.js to all admin pages using AssetController 

    [MAILPOET-4908]
    @samnajian
    samnajian committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    0909211 View commit details
    Browse the repository at this point in the history

  13. Fix regression for newly added translation 

    [MAILPOET-4908]
    @samnajian
    samnajian committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    6a72297 View commit details
    Browse the repository at this point in the history

  14. Add missing translation 

    [MAILPOET-4908]
    @samnajian
    samnajian committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    2a78525 View commit details
    Browse the repository at this point in the history

  15. Use @wordpress/i18n for coupon block 

    [MAILPOET-4908]
    @samnajian
    samnajian committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    ea9e144 View commit details
    Browse the repository at this point in the history

  16. Fix wrong import order 

    [MAILPOET-4908]
    @samnajian
    samnajian committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    80949f3 View commit details
    Browse the repository at this point in the history

  17. Add missing translatable messages 

    [MAILPOET-4908]
    @samnajian
    samnajian committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    c7041c6 View commit details
    Browse the repository at this point in the history

  18. Fix code formatting issue 

    [MAILPOET-4908]
    @samnajian
    samnajian committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    347d17b View commit details
    Browse the repository at this point in the history

  19. Fix the issue in image block not working with lodash 

    As per import of @wordpress/i18n, and since it's using lodash
We'll need to reset window._ to underscore where we have a hard
dependency to underscore

[MAILPOET-4908]
    @samnajian
    samnajian committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    a453f5b View commit details
    Browse the repository at this point in the history

  20. Manually bump version to beta.1 

    [MAILPOET-4908]
    @samnajian
    samnajian committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    5126750 View commit details
    Browse the repository at this point in the history

  21. Wait for coupon settings panel to close before proceeding 

    This should fix the flakiness of EditorCouponCest::addCoupon

[MAILPOET-4908]
    @samnajian
    samnajian committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    79ecd1a View commit details
    Browse the repository at this point in the history

  22. Use @wordpress/i18n for template boxes 

    [MAILPOET-4908]
    @samnajian
    samnajian committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    8ba94cd View commit details
    Browse the repository at this point in the history

  23. Use @wordpress/i18n for rest of common folder 

    [MAILPOET-4908]
    @samnajian
    samnajian committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    c575906 View commit details
    Browse the repository at this point in the history

  24. Add commons.js via wp_enqueue_script 

    [MAILPOET-4908]
    @samnajian
    samnajian committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    e2bd7ca View commit details
    Browse the repository at this point in the history

  25. Manually bump version to beta.3 

    [MAILPOET-4908]
    @samnajian
    samnajian committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    6a81218 View commit details
    Browse the repository at this point in the history

  26. Fix issue with newsletter form fields not getting translated 

    [MAILPOET-4908]
    @samnajian
    samnajian committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    d26ec6f View commit details
    Browse the repository at this point in the history

  27. Add missing code back 

    Some part of code had been removed by mistake for solving
merge conflicts

[MAILPOET-4908]
    @samnajian
    samnajian committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    00f1b5d View commit details
    Browse the repository at this point in the history

  28. Adjust translations:build command to use wp from vendor dir 

    [MAILPOET-4908]
    @samnajian
    samnajian committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    f392aeb View commit details
    Browse the repository at this point in the history

  29. Exclude irrelevant files from being parsed for translations 

    [MAILPOET-4908]
    @samnajian
    samnajian committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    3b2b4c3 View commit details
    Browse the repository at this point in the history

  30. Add a missing translations 

    [MAILPOET-4908]
    @samnajian
    samnajian committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    84fc7bf View commit details
    Browse the repository at this point in the history

  31. Fix translation for frequency in for re-engagement emails 

    [MAILPOET-4908]
    @samnajian
    samnajian committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    e2f0ac4 View commit details
    Browse the repository at this point in the history

  32. Add missing translation domains 

    [MAILPOET-4908]
    @samnajian
    samnajian committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    13a8587 View commit details
    Browse the repository at this point in the history