New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check whether github.com/pkg/errors
can be replaced with standard library functions
#12632
Closed
5 of 6 tasks
Comments
2 tasks
alexzurbonsen
changed the title
Replace
Check whether May 4, 2022
github.com/pkg/errors
with standard librarygithub.com/pkg/errors
can be replaced with standard library functions
1 task
SummaryThese PRs remove the uses of github.com/pkg/errors which is no longer maintained. However, this change will remove stack traces in the output.
I attached an example below of the change in output. I obtained this by modifying the source code so a test would fail. Old output:
New output
|
1 task
This was referenced May 16, 2022
This was referenced May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The module
github.com/pkg/errors
is no longer maintained, see for example pkg/errors#245.It seems like it can be removed and replaced by standard lib functionality (mainly
errors.Errorf
-->fmt.Errorf
), which includes all of the functionality, except for the stack traces, that are included in the error type frompkg/errors
. See for example this comment microsoft/go-winio#227 (comment).We should probably check whether removal is sensible and if yes replace it.
Progress:
this needs to be fixed in
The text was updated successfully, but these errors were encountered: