Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lte): replace deprecated errors module #12728

Closed
wants to merge 1 commit into from

Conversation

wolfseb
Copy link
Contributor

@wolfseb wolfseb commented May 16, 2022

Replace functions errors.Wrap and errors.Wrapf from the
github.com/pgk/errors package with fmt.Errorsf. Created in pairing
with Moritz Huebner.

Signed-off-by: Sebastian Wolf sebastian.wolf@tngtech.com

Summary

This PR implements the proposed solutions of ticket #12632 for the lte module.

Test Plan

Perform Unit tests.

Additional Information

  • This change is backwards-breaking

Replace functions `errors.Wrap` and `errors.Wrapf` from the
github.com/pgk/errors package with `fmt.Errorsf`. Created in pairing
with Moritz Huebner.

Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com>
@pull-request-size pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label May 16, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: orc8r Orchestrator-related issue label May 16, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2022

Oops! Looks like you failed the Semantic PR check.

Howto

♻️ Updated: ❌ The check is still failing the Semantic PR after the last commit.

@github-actions
Copy link
Contributor

feg-workflow

    2 files  202 suites   37s ⏱️
371 tests 371 ✔️ 0 💤 0
385 runs  385 ✔️ 0 💤 0

Results for commit fd75094.

@wolfseb wolfseb closed this May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: orc8r Orchestrator-related issue size/L Denotes a Pull Request that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant