Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(feg): replace deprecated errors module #12726

Merged
merged 1 commit into from Jun 1, 2022
Merged

refactor(feg): replace deprecated errors module #12726

merged 1 commit into from Jun 1, 2022

Conversation

wolfseb
Copy link
Contributor

@wolfseb wolfseb commented May 16, 2022 •
edited

Replace functions errors.Wrap and errors.Wrapf from the
github.com/pgk/errors package with fmt.Errorsf. Created in pairing
with Moritz Huebner.

Signed-off-by: Sebastian Wolf sebastian.wolf@tngtech.com

Summary

This PR implements the proposed solutions of ticket #12632 for the feg module.

Test Plan

Perform unit tests

Additional Information

Worked in pairing with @MoritzThomasHuebner

  • This change is backwards-breaking

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label May 16, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added component: cwf component: feg FEG-gateway related issues labels May 16, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2022 •
edited

feg-workflow

    2 files  202 suites   38s ⏱️
371 tests 371 ✔️ 0 💤 0 ❌
385 runs  385 ✔️ 0 💤 0 ❌

Results for commit 7ed0baa.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2022 •
edited

cloud-workflow

    7 files  355 suites   2m 15s ⏱️
979 tests 979 ✔️ 0 💤 0 ❌

Results for commit 7ed0baa.

♻️ This comment has been updated with latest results.

@maxhbr maxhbr mentioned this pull request May 16, 2022
Closed
6 tasks
@wolfseb wolfseb force-pushed the errors_to_stdlib_errors_feg branch 2 times, most recently from 88b55d9 to 250158d Compare May 17, 2022 01:53
@pull-request-size pull-request-size bot added size/L Denotes a Pull Request that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels May 17, 2022
@wolfseb wolfseb force-pushed the errors_to_stdlib_errors_feg branch 3 times, most recently from 26bf127 to fe8d4ba Compare May 17, 2022 05:49
@wolfseb wolfseb marked this pull request as ready for review May 17, 2022 07:08
@wolfseb wolfseb requested review from a team, aharonnovo and emakeev May 17, 2022 07:08
@wolfseb wolfseb force-pushed the errors_to_stdlib_errors_feg branch 3 times, most recently from a707103 to 29d87eb Compare May 17, 2022 08:53
alexzurbonsen
alexzurbonsen approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@alexzurbonsen alexzurbonsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me.

themarwhal
themarwhal reviewed May 17, 2022
View reviewed changes
Copy link
Member

@themarwhal themarwhal left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the resulting log look pretty much the same? Do you have a diff? (nvm I saw the attached issue :) )

@wolfseb wolfseb force-pushed the errors_to_stdlib_errors_feg branch from 29d87eb to c2d2f2f Compare May 24, 2022 02:13
@wolfseb wolfseb force-pushed the errors_to_stdlib_errors_feg branch 2 times, most recently from b64a540 to 72a6a7b Compare May 29, 2022 23:24
@wolfseb
refactor(feg): replace deprecated errors module
7ed0baa 
Replace functions from the github.com/pgk/errors package
with `fmt.Errorf` in /magma/feg. Created in pairing
with Moritz Huebner.

Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com>
@wolfseb wolfseb force-pushed the errors_to_stdlib_errors_feg branch from 72a6a7b to 7ed0baa Compare May 31, 2022 23:46
@sebathomas sebathomas merged commit 70ac776 into magma:master Jun 1, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
@wolfseb @emakeev
refactor(feg): replace deprecated errors module (magma#12726)
21bf686 
Replace functions from the github.com/pgk/errors package
with `fmt.Errorf` in /magma/feg. Created in pairing
with Moritz Huebner.

Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neudrino Neudrino Neudrino approved these changes

@themarwhal themarwhal themarwhal approved these changes

@alexzurbonsen alexzurbonsen alexzurbonsen approved these changes

@aharonnovo aharonnovo Awaiting requested review from aharonnovo

@emakeev emakeev Awaiting requested review from emakeev

Assignees
No one assigned
Labels
component: cwf component: feg FEG-gateway related issues size/L Denotes a Pull Request that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wolfseb @Neudrino @themarwhal @alexzurbonsen @sebathomas