Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dp): replace deprecated errors module #12727

Merged
merged 1 commit into from May 18, 2022

Conversation

wolfseb
Copy link
Contributor

@wolfseb wolfseb commented May 16, 2022

Replace functions errors.Wrap and errors.Wrapf from the
github.com/pgk/errors package with fmt.Errorsf. Created in pairing
with Moritz Huebner.

Signed-off-by: Sebastian Wolf sebastian.wolf@tngtech.com

Summary

This PR implements the proposed solutions of ticket #12632 for the dp module.

Test Plan

Perform Unit tests

Additional Information

  • This change is backwards-breaking

Replace functions `errors.Wrap` and `errors.Wrapf` from the
github.com/pgk/errors package with `fmt.Errorsf`. Created in pairing
with Moritz Huebner.

Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label May 16, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: orc8r Orchestrator-related issue label May 16, 2022
@wolfseb wolfseb marked this pull request as ready for review May 17, 2022 00:56
@wolfseb wolfseb requested review from a team and sklgromek May 17, 2022 00:56
Copy link
Contributor

@xbend xbend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wolfseb LGTM

@alexzurbonsen alexzurbonsen added the ready2merge This PR is ready to be merged (is approved and passes all required checks) label May 17, 2022
@sebathomas sebathomas merged commit 222e287 into magma:master May 18, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Replace functions `errors.Wrap` and `errors.Wrapf` from the
github.com/pgk/errors package with `fmt.Errorsf`. Created in pairing
with Moritz Huebner.

Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: orc8r Orchestrator-related issue ready2merge This PR is ready to be merged (is approved and passes all required checks) size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants