[CS] Update config for php-cs-fixer v2.0 and remove StyleCI config/badge #992
Conversation
.php_cs
Outdated
| //'ordered_class_elements' => true, | ||
| 'ordered_imports' => true, | ||
| 'php_unit_construct' => true, | ||
| 'php_unit_dedicate_assert' => true, |
.php_cs
Outdated
| ->setRules([ | ||
| //'@PHP56Migration' => true, | ||
| '@Symfony' => true, | ||
| //'@Symfony:risky' => true, |
There was a problem hiding this comment.
What does this enable? Do we possibly want to do so? We generally strictly follow Symfony's coding standings, short of long array syntax and a few other small differences.
There was a problem hiding this comment.
It is commented, just in case that you or someone want enable to experiment. The risky enable more agressive fixes, that not in all cases could be perfect. According to doc "Risky rule is a rule, which could change code behaviour. By default no risky rules are run."
.php_cs
Outdated
| $config = PhpCsFixer\Config::create() | ||
| ->setRiskyAllowed(true) | ||
| ->setRules([ | ||
| //'@PHP56Migration' => true, |
There was a problem hiding this comment.
Can we get rid of all commented entries?
There was a problem hiding this comment.
ok, I leave it just in case that you want enable someone of them, that actually could be good for the project. I will remove all commented
robfrawley
changed the title
.php_cs
Outdated
| '@Symfony' => true, | ||
| 'array_syntax' => ['syntax' => 'long'], | ||
| 'combine_consecutive_unsets' => true, | ||
| 'linebreak_after_opening_tag' => true, |
There was a problem hiding this comment.
This line (18), as well as line 22, 23, and 24 are indented using \t (tab) characters. Please ensure the whole document is written out using spaces.
There was a problem hiding this comment.
I just corrected it through the web interface
|
@shakaran You need to change the version constraint for |
.php_cs
Outdated
| @@ -0,0 +1,34 @@ | |||
| <?php | |||
| $header = <<<'EOF' | |||
|
|
|||
There was a problem hiding this comment.
This blank line needs to be removed, and the spaces before the other header lines need to be removed, as well. It should be:
$header = <<<'EOF'
This file is part of the `liip/LiipImagineBundle` project.
(c) https://github.com/liip/LiipImagineBundle/graphs/contributors
For the full copyright and license information, please view the LICENSE.md
file that was distributed with this source code.
EOF;
| @@ -0,0 +1,34 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Add a newline after the opening <?php and add our copyright, making it:
<?php
/*
* This file is part of the `liip/LiipImagineBundle` project.
*
* (c) https://github.com/liip/LiipImagineBundle/graphs/contributors
*
* For the full copyright and license information, please view the LICENSE.md
* file that was distributed with this source code.
*/
$header = <<<'EOF'
.php_cs
Outdated
| @@ -12,42 +12,17 @@ EOF; | |||
| $config = PhpCsFixer\Config::create() | |||
| ->setRiskyAllowed(true) | |||
| ->setRules([ | |||
There was a problem hiding this comment.
We need to obey the cs rules defined here, in this file, itself. :-) Change to long array syntax here, and elsewhere in the file where short array syntax is used.
|
@shakaran @antoligy @cedricziel I think we should take this opportunity to update our current rule set and add some additional ones that have merit. The ruleset I'd like to run past everyone is the following: array(
'@Symfony' => true,
'@Symfony:risky' => true,
'array_syntax' => array('syntax' => 'long'),
'combine_consecutive_unsets' => true,
'header_comment' => array('header' => $header),
'heredoc_to_nowdoc' => true,
'linebreak_after_opening_tag' => true,
'list_syntax' => array('syntax' => 'long'),
'no_short_echo_tag' => true,
'no_unreachable_default_argument_value' => true,
'no_useless_else' => true,
'no_useless_return' => true,
'ordered_class_elements' => true,
'ordered_imports' => true,
'php_unit_construct' => true,
'php_unit_dedicate_assert' => true,
'phpdoc_add_missing_param_annotation' => true,
'phpdoc_order' => true,
'psr4' => true,
'strict_comparison' => true,
'strict_param' => true,
)Give robfrawley@e172b74 a look to help in visualizing all the changes that would be introduced by the ruleset changes noted above (the commit also includes a few manual changes I made to some bad comparison operations that were otherwise broken by these rules, but such changes only need to be made once to resolve the issue and are for the better, anyway). Note: the yoda-style changes aren't actually part of any of the ruleset changes here; instead, the |
|
@robfrawley so I need to add something more to this PR to be merged? Or I have to update with the ruleset that you indicated? |
|
I am just curious. |
|
another candidate for 2.0 |
|
I created the Pull request #1040 in the 2.0 branch :) |
|
thx |
|
@shakaran could you please update your MR taking into account @robfrawley's comments ? |
|
lets not touch cs in legacy code anymore. |
This is for the comment in PR #927 to use again PHP CS Fixer 2.0 instead 1.0