[CS] Update config for php-cs-fixer v2.0 and remove StyleCI config/badge #992
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| <?php | ||
| $header = <<<'EOF' | ||
|
|
||
|
There was a problem hiding this comment. This blank line needs to be removed, and the spaces before the other header lines need to be removed, as well. It should be: $header = <<<'EOF'
This file is part of the `liip/LiipImagineBundle` project.
(c) https://github.com/liip/LiipImagineBundle/graphs/contributors
For the full copyright and license information, please view the LICENSE.md
file that was distributed with this source code.
EOF; |
||
| This file is part of the `liip/LiipImagineBundle` project. | ||
|
|
||
| (c) https://github.com/liip/LiipImagineBundle/graphs/contributors | ||
|
|
||
| For the full copyright and license information, please view the LICENSE.md | ||
| file that was distributed with this source code. | ||
| EOF; | ||
|
|
||
| $config = PhpCsFixer\Config::create() | ||
| ->setRiskyAllowed(true) | ||
| ->setRules([ | ||
|
There was a problem hiding this comment. We need to obey the cs rules defined here, in this file, itself. :-) Change to long array syntax here, and elsewhere in the file where short array syntax is used. |
||
| '@Symfony' => true, | ||
| 'array_syntax' => ['syntax' => 'long'], | ||
| 'combine_consecutive_unsets' => true, | ||
| 'linebreak_after_opening_tag' => true, | ||
| 'header_comment' => ['header' => $header], | ||
| 'list_syntax' => ['syntax' => 'long'], | ||
| 'no_short_echo_tag' => true, | ||
| 'ordered_imports' => true, | ||
| 'php_unit_construct' => true, | ||
| 'php_unit_dedicate_assert' => true, | ||
| 'phpdoc_order' => true, | ||
| ]) | ||
| ->setFinder( | ||
| PhpCsFixer\Finder::create() | ||
| ->name("*.php") | ||
| ->name("*.twig") | ||
| ->exclude('vendor/var') | ||
| ->in(__DIR__) | ||
| ) | ||
| ; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a newline after the opening
<?phpand add our copyright, making it: