Revert to php-cs-fixer 1.x and run fixer #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robfrawley
added
Level: Bug 🐞
|
We should think about using the phar instead of pulling it in our dependency tree. |
cedricziel
approved these changes
May 8, 2017
lsmith77
removed
the
State: Reviewing
Merged
|
@robfrawley it seems that Style CI has given up with upgrade to 2.x php-cs-fixer, so probably it is better rewrite the .php_cs file instead and use new version and forget about .styleci.yml |
|
@shakaran Yes, I know the state of Style CI integration with php-cs-fixer is stalled. This was simply a quick fix; a more long-term solution needs to be implemented, for sure. |
|
@robfrawley would you accept a PR where I implement the exact same filters/fixers, etc in the .php_cs file? So php-cs-fixer 2.x version could be used again? |
|
Sure would. ;-) |
|
@robfrawley Done PR #992 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The move to php-cs-fixer
2.xwas done without migrating the.styleci.ymlrules. This pull request reverts ourrequire-devdependency back to1.x, amends the.php_cs.distfile for simplicity, and includes fixes from aphp-cs-fixerrun.We'll be stuck with this version until the following are fixed: