feat: Better error reporting when features are disabled

[thomaseizinger]

Description

In case support for e.g. RSA keys is disabled at compile-time, we will now print a better error message. For example:

Failed to dial Some(PeerId("QmcZf59bWwK5XFi76CZX8cbJ4BhTzzA3gU1ZjYZcYW3dwt")): Failed to negotiate transport protocol(s): [(/dnsaddr/bootstrap.libp2p.io/p2p/QmcZf59bWwK5XFi76CZX8cbJ4BhTzzA3gU1ZjYZcYW3dwt): : Handshake failed: Handshake failed: Invalid public key: Key decoding error: RSA keys are unsupported)]

Fixes #2971.

Links to any relevant issues

Depends-On: #3081

Open Questions

Change checklist

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• A changelog entry has been made in the appropriate crates

[mxinden]

As always, great work. Thank you for tackling this so thoroughly. Thanks for breaking it up into smaller meaningful commits.

[thomaseizinger]

@mxinden test-plan doesn't seem to be happy :(

https://github.com/libp2p/rust-libp2p/actions/runs/3186899238/jobs/5197936812

[mxinden]

CI is failing with:

 error: failed to select a version for `zeroize`.
    ... required by package `der v0.6.0`
    ... which satisfies dependency `der = "^0.6"` of package `pkcs8 v0.9.0`
    ... which satisfies dependency `pkcs8 = "^0.9"` of package `sec1 v0.3.0`
    ... which satisfies dependency `sec1 = "^0.3.0"` of package `libp2p-core v0.37.0 (https://github.com/libp2p/rust-libp2p?rev=fd870f8f4ee1fe54ff605869632ea7e21ecfd3b7#fd870f8f)`
    ... which satisfies git dependency `libp2p-core` of package `libp2p v0.49.0 (https://github.com/libp2p/rust-libp2p?rev=fd870f8f4ee1fe54ff605869632ea7e21ecfd3b7#fd870f8f)`
    ... which satisfies git dependency `libp2pmaster` of package `testplan v0.1.0 (/usr/src/testplan/plan)`
versions that meet the requirements `^1.5` are: 1.5.7, 1.5.6, 1.5.5, 1.5.4, 1.5.3

all possible versions conflict with previously selected packages.

  previously selected package `zeroize v1.3.0`
    ... which satisfies dependency `zeroize = "^1"` (locked to 1.3.0) of package `chacha20 v0.8.2`
    ... which satisfies dependency `chacha20 = "^0.8"` (locked to 0.8.2) of package `chacha20poly1305 v0.9.1`
    ... which satisfies dependency `chacha20poly1305 = "^0.9"` (locked to 0.9.1) of package `snow v0.9.0`
    ... which satisfies dependency `snow = "^0.9.0"` (locked to 0.9.0) of package `libp2p-noise v0.35.0`
    ... which satisfies dependency `libp2p-noise = "^0.35.0"` (locked to 0.35.0) of package `libp2p v0.44.0`
    ... which satisfies dependency `libp2pv0440 = "^0.44.0"` (locked to 0.44.0) of package `testplan v0.1.0 (/usr/src/testplan/plan)`

failed to select a version for `zeroize` which could resolve this conflict

I would like to test this with a fresh Cargo.lock. I am guessing that previously cached runs influence this one. @laurentsenta is there anyway I can run the CI job without any cache from previous runs?

[mxinden]

I should have included this in #2931 but I forgot.

Can you update the pull request now that v0.49.0 is released @thomaseizinger?

[mxinden]

@thomaseizinger libp2p/test-plans#72 is merged. Can you update this pull request?

[mergify]

This pull request has merge conflicts. Could you please resolve them @thomaseizinger? 🙏

[melekes]

👍

[thomaseizinger]

Here we go!

[mxinden]

🎉