Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ping/rust: Run cargo update #69

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Nov 2, 2022

Updates dependency. In the hope to resolve conflict from libp2p/rust-libp2p#2972.

Updates dependency. In the hope to resolve conflict from
libp2p/rust-libp2p#2972.
@mxinden
Copy link
Member Author

mxinden commented Nov 2, 2022

Proceeding here given that @laurentsenta is out. Happy to do any follow ups.

@mxinden mxinden merged commit 3d51093 into libp2p:master Nov 2, 2022
@laurentsenta
Copy link
Collaborator

@mxinden thanks for taking care of this fix.
Would it make sense to call cargo update when we build master and custom branches? Since the dependencies might change there.

We do something similar in go-libp2p:

RUN cd ${PLAN_DIR} && \
go mod download github.com/libp2p/go-libp2p && \
go mod tidy -compat={{ .GoVersion }}

@laurentsenta
Copy link
Collaborator

We'd do this in

RUN cd ./plan/ && \
cargo build --features="${CARGO_FEATURES}"

@mxinden
Copy link
Member Author

mxinden commented Nov 14, 2022

For the record, discussion moved here #68 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants