Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Better error reporting when features are disabled #2972

Merged
merged 39 commits into from
Nov 23, 2022
Merged

feat: Better error reporting when features are disabled #2972

merged 39 commits into from
Nov 23, 2022

Commits on Oct 3, 2022

  1. Return snow::Error as source 

    This TODO can be resolved now.
    @thomaseizinger
    thomaseizinger committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    f83ccea View commit details
    Browse the repository at this point in the history

  2. Use thiserror macro to generate error

    @thomaseizinger
    thomaseizinger committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    d64c216 View commit details
    Browse the repository at this point in the history

  3. Move NoiseError to lib.rs 

    Having an entire module for one struct doesn't quite cut it.
    @thomaseizinger
    thomaseizinger committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    9218c5d View commit details
    Browse the repository at this point in the history

  4. Be more specific about error case for bad signatures

    @thomaseizinger
    thomaseizinger committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    330e3ff View commit details
    Browse the repository at this point in the history

  5. Be more specific about error case for unexpected key in authentication

    @thomaseizinger
    thomaseizinger committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    992706b View commit details
    Browse the repository at this point in the history

  6. Use ? for better indentation

    @thomaseizinger
    thomaseizinger committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    84ca840 View commit details
    Browse the repository at this point in the history

  7. Even more use of ?

    @thomaseizinger
    thomaseizinger committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    b9ffed9 View commit details
    Browse the repository at this point in the history

  8. Use combinators on ALL the things

    @thomaseizinger
    thomaseizinger committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    ae8b833 View commit details
    Browse the repository at this point in the history

  9. Be more specific about error case when validating key length

    @thomaseizinger
    thomaseizinger committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    e1c80e3 View commit details
    Browse the repository at this point in the history

  10. Include source of decoding error 

    This should make for better error messages when support for certain
keys is disabled.

Fixes #2971.
    @thomaseizinger
    thomaseizinger committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    3c15f9f View commit details
    Browse the repository at this point in the history

  11. Add changelog entry

    @thomaseizinger
    thomaseizinger committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    a937f16 View commit details
    Browse the repository at this point in the history

  12. Slightly revise coding style of ipfs-kad example

    @thomaseizinger
    thomaseizinger committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    2531ab5 View commit details
    Browse the repository at this point in the history

  13. Be more specific about what is not supported

    @thomaseizinger
    thomaseizinger committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    59ba1dd View commit details
    Browse the repository at this point in the history

  14. Don't include sources in Display impl 

    This leads to double printing of errors when iterating the source
chain.
    @thomaseizinger
    thomaseizinger committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    d789d5b View commit details
    Browse the repository at this point in the history

  15. Print source chain on DialError

    @thomaseizinger
    thomaseizinger committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    097cf5e View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2022

  1. Format code

    @thomaseizinger
    thomaseizinger committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    0826287 View commit details
    Browse the repository at this point in the history

  2. Fix bad parenthesis

    @thomaseizinger
    thomaseizinger committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    5c5281f View commit details
    Browse the repository at this point in the history

  3. Fix clippy error

    @thomaseizinger
    thomaseizinger committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    76cdbbe View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. Introduce dedicated constructors for DecodingError

    @thomaseizinger
    thomaseizinger committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    c81f730 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into 2971-better-error-message

    @mxinden
    mxinden committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    18c5c02 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into 2971-better-error-message

    @mxinden
    mxinden committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    fd870f8 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2022

  1. Merge branch 'master' into 2971-better-error-message

    @mxinden
    mxinden committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    682b363 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. Merge branch 'master' into 2971-better-error-message

    @thomaseizinger
    thomaseizinger committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    f6017db View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. Merge branch 'master' into 2971-better-error-message

    @thomaseizinger
    thomaseizinger committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    1a49349 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. Merge branch 'master' into 2971-better-error-message

    @thomaseizinger
    thomaseizinger committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    7fc3c61 View commit details
    Browse the repository at this point in the history

  2. Bump version accordingly

    @thomaseizinger
    thomaseizinger committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    db129cb View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. Merge branch 'master' into 2971-better-error-message

    @thomaseizinger
    thomaseizinger committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    8a75a12 View commit details
    Browse the repository at this point in the history

  2. Increase libp2p-core version to 0.37.1

    @thomaseizinger
    thomaseizinger committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    513b920 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. Merge branch 'master' into 2971-better-error-message

    @mxinden
    mxinden committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    2fad2ac View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. Merge branch 'master' into 2971-better-error-message

    @thomaseizinger
    thomaseizinger committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    3763ddf View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. Merge branch 'master' into 2971-better-error-message

    @thomaseizinger
    thomaseizinger committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    daaccd3 View commit details
    Browse the repository at this point in the history

  2. Fix bad boolean logic 

    We only need this if one of these is not enabled, i.e. they are
`not(all)` enabled.
    @thomaseizinger
    thomaseizinger committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    b04b367 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. Merge branch 'master' into 2971-better-error-message

    @thomaseizinger
    thomaseizinger committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    d8426bf View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2022

  1. Merge branch 'master' into 2971-better-error-message

    @thomaseizinger
    thomaseizinger committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    2c348c6 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary feature activation 

    This is now released and available on crates.io.
    @thomaseizinger
    thomaseizinger committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    cedd5a1 View commit details
    Browse the repository at this point in the history

  3. Revert "Remove unnecessary feature activation" 

    This reverts commit cedd5a1.
    @thomaseizinger
    thomaseizinger committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    47e3772 View commit details
    Browse the repository at this point in the history

  4. Fix semver problem

    @thomaseizinger
    thomaseizinger committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    7a7522b View commit details
    Browse the repository at this point in the history

  5. MOAR CONDITIONALS

    @thomaseizinger
    thomaseizinger committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    60d03f2 View commit details
    Browse the repository at this point in the history

  6. Fmt

    @thomaseizinger
    thomaseizinger committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    a549775 View commit details
    Browse the repository at this point in the history