Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly update dependencies lockfile v2 #3275

Merged
merged 3 commits into from Aug 9, 2022
Merged

Conversation

natiz
Copy link
Contributor

@natiz natiz commented Aug 2, 2022

npm lockfile v2 includes dependencies and devDependencies,
this commit updates those based on the updated package.

Description

Follow up of PR #3091, also update lockfile v2 packages."".dependencies and packages."".devDependencies keys.

Motivation and Context

Solves an issue with npm lockfile v2, where dependencies/devDependencies are not properly updated.

How Has This Been Tested?

Tested locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

npm lockfile v2 includes dependencies and devDependencies,
this commit updates those based on the updated package.
@natiz
Copy link
Contributor Author

natiz commented Aug 5, 2022

@JamesHenry can you PTAL?

@JamesHenry JamesHenry requested a review from fahslaj August 8, 2022 15:04
@fahslaj
Copy link
Contributor

fahslaj commented Aug 9, 2022

Thank you @natiz !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants