fix: properly update dependencies lockfile v2 (#3275)

lerna · Aug 9, 2022 · d7c398b · d7c398b
1 parent 4f9f301
commit d7c398b
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 3 deletions.
diff --git a/__fixtures__/lockfile-leaf-v2/packages/package-1/package-lock.json b/__fixtures__/lockfile-leaf-v2/packages/package-1/package-lock.json
diff --git a/__fixtures__/lockfile-leaf-v2/packages/package-1/package.json b/__fixtures__/lockfile-leaf-v2/packages/package-1/package.json
@@ -2,6 +2,10 @@
   "name": "package-1",
   "version": "1.0.0",
   "dependencies": {
-    "tiny-tarball": "^1.0.0"
+    "tiny-tarball": "^1.0.0",
+    "package-2": "^1.0.0"
+  },
+  "devDependencies": {
+    "package-3": "2.0.0"
   }
 }
diff --git a/commands/version/__tests__/update-lockfile-version.test.js b/commands/version/__tests__/update-lockfile-version.test.js
@@ -30,14 +30,18 @@ test("updateLockfileVersion with lockfile v2", async () => {
   const [pkg] = await getPackages(cwd);
 
   pkg.version = "2.0.0";
+  pkg.dependencies["package-1"] = "^2.0.0";
+  pkg.devDependencies["package-2"] = "3.0.0";
 
   const returnedLockfilePath = await updateLockfileVersion(pkg);
 
   expect(returnedLockfilePath).toBe(path.join(pkg.location, "package-lock.json"));
   expect(Array.from(loadJsonFile.registry.keys())).toStrictEqual(["/packages/package-1"]);
   const updatedLockfile = fs.readJSONSync(returnedLockfilePath);
   expect(updatedLockfile).toHaveProperty("version", "2.0.0");
-  expect(updatedLockfile).toHaveProperty(["packages", "", "version"], "2.0.0");
+  expect(updatedLockfile).toHaveProperty(["packages", "", "dependencies", "package-1"], "^2.0.0");
+  expect(updatedLockfile).toHaveProperty(["packages", "", "dependencies", "tiny-tarball"], "^1.0.0");
+  expect(updatedLockfile).toHaveProperty(["packages", "", "devDependencies", "package-2"], "3.0.0");
 });
 
 test("updateLockfileVersion without sibling lockfile", async () => {

diff --git a/commands/version/lib/update-lockfile-version.js b/commands/version/lib/update-lockfile-version.js
@@ -18,6 +18,12 @@ function updateLockfileVersion(pkg) {
 
       if (obj.packages && obj.packages[""]) {
         obj.packages[""].version = pkg.version;
+        if (obj.packages[""].dependencies) {
+          obj.packages[""].dependencies = pkg.dependencies;
+        }
+        if (obj.packages[""].devDependencies) {
+          obj.packages[""].devDependencies = pkg.devDependencies;
+        }
       }
 
       return writeJsonFile(lockfilePath, obj, {