Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(version): properly update dependencies npm lockfile v2 #306

Merged
merged 1 commit into from Aug 10, 2022

Conversation

ghiscoding
Copy link
Member

npm lockfile v2 includes dependencies and devDependencies,
this commit updates those based on the updated package.

Description

As per Lerna PR

Follow up of PR lerna/lerna#3091, also update lockfile v2 packages."".dependencies and packages."".devDependencies keys.

Motivation and Context

As per Lerna PR 3275

Solves an issue with npm lockfile v2, where dependencies/devDependencies are not properly updated.

How Has This Been Tested?

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #306 (0abfa85) into main (5927f80) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
+ Coverage   96.15%   96.15%   +0.01%     
==========================================
  Files         145      145              
  Lines        4224     4228       +4     
  Branches      883      885       +2     
==========================================
+ Hits         4061     4065       +4     
  Misses        163      163              
Impacted Files Coverage Δ
...ackages/version/src/lib/update-lockfile-version.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit bc374c5 into main Aug 10, 2022
@ghiscoding ghiscoding deleted the bugfix/yarn-lock-v2 branch August 10, 2022 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant