Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Improved error logging for unmatched routes and route not found #45206

Merged

Conversation

i386
Copy link
Contributor

@i386 i386 commented Dec 6, 2022

Recreating #45191 as it was closed a little too early for me to provide an update based on feedback.

This change adds some improved error messages so that poor client usages (for example, older versions of mobile clients) can be identified via sentry logging etc. At the moment this is impossible to do without logging every request.

The change targets the following:

  • handleMatchedRoute's NotFoundHttpException
  • methodNotAllowed's MethodNotAllowedHttpException

@i386
Copy link
Contributor Author

i386 commented Dec 6, 2022

updated the change to fix the style issue but not sure why its not running again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants