[9.x] Improved error logging for unmatched routes and route not found (…

…#45206) * Improved error logging for unmatched routes and route not found * Update AbstractRouteCollection.php * Update AbstractRouteCollection.php * Update AbstractRouteCollection.php
laravel · Dec 7, 2022 · 5fae417 · 5fae417
1 parent cad86c1
commit 5fae417
Showing 1 changed file with 29 additions and 2 deletions.
diff --git a/src/Illuminate/Routing/AbstractRouteCollection.php b/src/Illuminate/Routing/AbstractRouteCollection.php
@@ -41,7 +41,10 @@ protected function handleMatchedRoute(Request $request, $route)
             return $this->getRouteForMethods($request, $others);
         }
 
-        throw new NotFoundHttpException;
+        throw new NotFoundHttpException(sprintf(
+            'The route %s could not be found.',
+            $request->path()
+        ));
     }
 
     /**
@@ -101,7 +104,30 @@ protected function getRouteForMethods($request, array $methods)
             }))->bind($request);
         }
 
-        $this->methodNotAllowed($methods, $request->method());
+        $this->requestMethodNotAllowed($request, $methods, $request->method());
+    }
+
+    /**
+     * Throw a method not allowed HTTP exception.
+     *
+     * @param  \Illuminate\Http\Request  $request
+     * @param  array  $others
+     * @param  string  $method
+     * @return void
+     *
+     * @throws \Symfony\Component\HttpKernel\Exception\MethodNotAllowedHttpException
+     */
+    protected function requestMethodNotAllowed($request, array $others, $method)
+    {
+        throw new MethodNotAllowedHttpException(
+            $others,
+            sprintf(
+                'The %s method is not supported for route %s. Supported methods: %s.',
+                $request->path(),
+                $method,
+                implode(', ', $others)
+            )
+        );
     }
 
     /**
@@ -110,6 +136,7 @@ protected function getRouteForMethods($request, array $methods)
      * @param  array  $others
      * @param  string  $method
      * @return void
+     * @deprecated use requestMethodNotAllowed
      *
      * @throws \Symfony\Component\HttpKernel\Exception\MethodNotAllowedHttpException
      */