[9.x] Improved error logging for unmatched routes and route not found #45191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
reviewed
Dec 6, 2022
| * @param array $others | ||
| * @param string $method | ||
| * @return void | ||
| * | ||
| * @throws \Symfony\Component\HttpKernel\Exception\MethodNotAllowedHttpException | ||
| */ | ||
| protected function methodNotAllowed(array $others, $method) | ||
| protected function methodNotAllowed($request, array $others, $method) |
There was a problem hiding this comment.
This is a breaking change to the method signature.
There was a problem hiding this comment.
We can have two of them. One for the old behaviour and one for the new behaviour.
driesvints
changed the title
|
@taylorotwell why close? |
|
Recreated #45206 based on feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds some improved error messages so that poor client usages (for example, older versions of mobile clients) can be identified via sentry logging etc. At the moment this is impossible to do without logging every request.
The change targets the following: