Try with public property

laravel · Oct 9, 2020 · 551d587 · 551d587
1 parent 3203e95
commit 551d587
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 5 deletions.
diff --git a/src/Illuminate/Database/Connection.php b/src/Illuminate/Database/Connection.php
@@ -40,7 +40,7 @@ class Connection implements ConnectionInterface
      *
      * @var \PDO|\Closure
      */
-    protected $readPdo;
+    public $readPdo;
 
     /**
      * The name of the connected database.

diff --git a/tests/Database/DatabaseConnectionTest.php b/tests/Database/DatabaseConnectionTest.php
@@ -55,6 +55,7 @@ public function testSelectOneCallsSelectAndReturnsSingleResult()
         $this->assertSame('foo', $connection->selectOne('foo', ['bar' => 'baz']));
     }
 
+    /** @group Foo */
     public function testSelectProperlyCallsPDO()
     {
         $pdo = $this->getMockBuilder(DatabaseConnectionTestMockPDO::class)->setMethods(['prepare'])->getMock();
@@ -66,7 +67,7 @@ public function testSelectProperlyCallsPDO()
         $statement->expects($this->once())->method('fetchAll')->willReturn(['boom']);
         $pdo->expects($this->once())->method('prepare')->with('foo')->willReturn($statement);
         $mock = $this->getMockConnection(['prepareBindings'], $writePdo);
-        $mock->setReadPdo($pdo);
+        $mock->readPdo = $pdo;
         $mock->expects($this->once())->method('prepareBindings')->with($this->equalTo(['foo' => 'bar']))->willReturn(['foo' => 'bar']);
         $results = $mock->select('foo', ['foo' => 'bar']);
         $this->assertEquals(['boom'], $results);

diff --git a/tests/Database/DatabaseEloquentBuilderTest.php b/tests/Database/DatabaseEloquentBuilderTest.php
@@ -1044,7 +1044,6 @@ public function testWhereKeyMethodWithStringZero()
         $builder->whereKey($int);
     }
 
-    /** @group Foo */
     public function testWhereKeyMethodWithStringNull()
     {
         $model = new EloquentBuilderTestStubStringPrimaryKey();
@@ -1097,7 +1096,6 @@ public function testWhereKeyNotMethodWithStringZero()
         $builder->whereKeyNot($int);
     }
 
-    /** @group Foo */
     public function testWhereKeyNotMethodWithStringNull()
     {
         $model = new EloquentBuilderTestStubStringPrimaryKey();

diff --git a/tests/Mail/MailSesTransportTest.php b/tests/Mail/MailSesTransportTest.php
@@ -13,7 +13,6 @@
 
 class MailSesTransportTest extends TestCase
 {
-    /** @group Foo */
     public function testGetTransport()
     {
         $container = new Container();