Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] PHP 8 Support #1214

Closed
wants to merge 1 commit into from
Closed

Conversation

MarkVaughn
Copy link

@MarkVaughn MarkVaughn commented Feb 3, 2022

For migrating from LTS version 6 to LTS version 9 there is no PHP version overlap.
Thanks to the work done here laravel/framework#33388 and so much of the guts being shared, it seems safe to allow PHP 8 on lumen 6.x
This will help us with our migrations to PHP 8 so we can upgrade to Lumen 9 once it becomes available.

@MarkVaughn MarkVaughn changed the title PHP 8 Support [6.x] PHP 8 Support Feb 3, 2022
@GrahamCampbell
Copy link
Member

👎 Lumen 6 is not LTS.

@GrahamCampbell
Copy link
Member

Only the main Laravel framework gets LTS releases.

@MarkVaughn
Copy link
Author

all the components lumen uses are PHP8 compatible, the choice to be on lumen 6 rather than lumen 7 benefits from the laravel 6s LTS fixes. This small change should have no impact, and really just seems to be an oversight

@GrahamCampbell
Copy link
Member

It's not an oversight. Lumen 6 is already EOL.

@GrahamCampbell
Copy link
Member

The tests passing here is not a good indication that Lumen 6 will work properly on PHP 8, and the wide version constraint adds the further problem that people will try to install it on PHP 8.1 too, where it definitely doesn't work. I think we're best of making people force work around the version constraint if they really wanna install it on PHP 8, so it's super clear it's not supported.

@taylorotwell
Copy link
Member

This would likely need more thorough review of the stuff that is Lumen specific and not part of Illuminate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants