Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PodAffinityTerm.NamespaceSelector and CrossNamespacePodAffinity Quota scope APIs #98378

Closed
wants to merge 1 commit into from
Closed

Add PodAffinityTerm.NamespaceSelector and CrossNamespacePodAffinity Quota scope APIs #98378

wants to merge 1 commit into from

Conversation

ahg-g
Copy link
Member

@ahg-g ahg-g commented Jan 25, 2021 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds NamespaceSelector to PodAffinityTerm and CrossNamespacePodAffinity quota scope APIs

Which issue(s) this PR fixes:
Part of #97203

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

1. PodAffinityTerm includes a namespaceSelector field to allow selecting eligible namespaces based on their labels. 
2. A new CrossNamespacePodAffinity quota scope API that allows restricting which namespaces allowed to use PodAffinityTerm with corss-namespace reference via namespaceSelector or namespaces fields.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Please use the following format for linking documentation:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 25, 2021
@k8s-ci-robot
Copy link
Contributor

@ahg-g: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Jan 25, 2021
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 25, 2021
@ahg-g ahg-g force-pushed the ahg-nss-api branch 4 times, most recently from b764fed to 4243606 Compare January 26, 2021 19:32
@ahg-g
Copy link
Member Author

ahg-g commented Jan 26, 2021

/hold

waiting for kubernetes/enhancements#2251 to merge first

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2021
@ahg-g ahg-g changed the title WIP: Add NamespaceSelector to PodAffinityTerm API Add NamespaceSelector to PodAffinityTerm API Jan 26, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2021
@ahg-g
Copy link
Member Author

ahg-g commented Jan 26, 2021

/sig scheduling
/assign @liggitt

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Jan 26, 2021
@ahg-g
Copy link
Member Author

ahg-g commented Jan 26, 2021

/assign @alculquicondor @Huang-Wei

@ahg-g ahg-g mentioned this pull request Jan 26, 2021
Merged
@ahg-g ahg-g mentioned this pull request Jan 29, 2021
Merged
Huang-Wei
Huang-Wei reviewed Jan 29, 2021
View reviewed changes
Copy link
Member

@Huang-Wei Huang-Wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits. LGTM otherwise.

pkg/api/resourcequota/util.go Outdated Show resolved Hide resolved
pkg/api/resourcequota/util.go Outdated Show resolved Hide resolved
pkg/api/resourcequota/util.go Outdated Show resolved Hide resolved
alculquicondor
alculquicondor reviewed Feb 2, 2021
View reviewed changes
pkg/apis/core/validation/validation.go Outdated Show resolved Hide resolved
pkg/api/resourcequota/util.go Outdated Show resolved Hide resolved
@ahg-g
Copy link
Member Author

ahg-g commented Feb 4, 2021

@liggitt the KEP is merged and implementation PRs are up: #98582 and #98446

@ahg-g ahg-g force-pushed the ahg-nss-api branch 2 times, most recently from 7f6bb02 to 9e6706e Compare February 5, 2021 20:08
@ahg-g
Copy link
Member Author

ahg-g commented Feb 5, 2021

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 5, 2021
@ahg-g ahg-g mentioned this pull request Feb 8, 2021
Closed
6 tasks
@ahg-g
Copy link
Member Author

ahg-g commented Feb 8, 2021

/retest

@ahg-g ahg-g mentioned this pull request Feb 8, 2021
Closed
12 tasks
@ahg-g
Copy link
Member Author

ahg-g commented Feb 9, 2021

@liggitt friendly ping

@liggitt
Copy link
Member

liggitt commented Feb 9, 2021 •
edited

@liggitt friendly ping

ack, getting through KEP reviews for enhancements freeze today, then will start working through implementation PRs

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ahg-g
To complete the pull request process, please assign liggitt after the PR has been reviewed.
You can assign the PR to them by writing /assign @liggitt in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Feb 10, 2021
@alculquicondor
Copy link
Member

LGTM

@alculquicondor
Copy link
Member

good for squash

@liggitt liggitt added this to Changes requested in API Reviews Feb 16, 2021
@ahg-g
Copy link
Member Author

ahg-g commented Feb 17, 2021

/close

This will be reviewed as part of #98582

@k8s-ci-robot
Copy link
Contributor

@ahg-g: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 17, 2021
@k8s-ci-robot
Copy link
Contributor

@ahg-g: Closed this PR.

In response to this:

/close

This will be reviewed as part of #98582

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liggitt liggitt removed this from Changes requested in API Reviews Feb 22, 2021
@ahg-g ahg-g deleted the ahg-nss-api branch October 25, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@Huang-Wei Huang-Wei Huang-Wei left review comments

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@davidopp davidopp Awaiting requested review from davidopp

Assignees

@liggitt liggitt

@alculquicondor alculquicondor

@Huang-Wei Huang-Wei

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ahg-g @k8s-ci-robot @liggitt @alculquicondor @Huang-Wei