Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements NamespaceSelector for pod affinity #98446

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Implements NamespaceSelector for pod affinity #98446

merged 1 commit into from
Mar 4, 2021

Conversation

ahg-g
Copy link
Member

@ahg-g ahg-g commented Jan 26, 2021 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Implements NamespaceSelector for pod affinity.

Which issue(s) this PR fixes:
Part of #97203

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 26, 2021
@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 26, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2021
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@ahg-g ahg-g mentioned this pull request Jan 29, 2021
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 29, 2021
alculquicondor
alculquicondor reviewed Feb 5, 2021
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a long PR. I will take a rest and come back :)

pkg/scheduler/eventhandlers_test.go Outdated Show resolved Hide resolved
pkg/scheduler/internal/queue/scheduling_queue.go Outdated Show resolved Hide resolved
pkg/scheduler/internal/queue/scheduling_queue.go Outdated Show resolved Hide resolved
pkg/scheduler/internal/queue/scheduling_queue.go Outdated Show resolved Hide resolved
pkg/scheduler/internal/queue/scheduling_queue.go Show resolved Hide resolved
pkg/scheduler/framework/plugins/interpodaffinity/filtering.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/interpodaffinity/filtering.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/interpodaffinity/filtering.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/types.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/types.go Outdated Show resolved Hide resolved
@ahg-g
Copy link
Member Author

ahg-g commented Feb 5, 2021

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 5, 2021
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 2, 2021
@ahg-g
Copy link
Member Author

ahg-g commented Mar 2, 2021

@alculquicondor @Huang-Wei @damemi I tested the struct pattern for passing feature gates in this PR, I like it better than the With option. PTAL (sorry, it is half merged into the second commit :().

@alculquicondor
Copy link
Member

Aldo Culquicondor Wei Huang Mike Dame I tested the struct pattern for passing feature gates in this PR, I like it better than the With option. PTAL (sorry, it is half merged into the second commit :().

I like it. It saves a few lines of code vs With.

@ahg-g
Copy link
Member Author

ahg-g commented Mar 2, 2021

Aldo Culquicondor Wei Huang Mike Dame I tested the struct pattern for passing feature gates in this PR, I like it better than the With option. PTAL (sorry, it is half merged into the second commit :().

I like it. It saves a few lines of code vs With.

Yeah, I think it is makes it easier to track features as well. Also, with the type being defined in a separate pkg under plugins, we avoid making it part of the framework interface.

@Huang-Wei
Copy link
Member

@alculquicondor @Huang-Wei @damemi I tested the struct pattern for passing feature gates in this PR, I like it better than the With option. PTAL (sorry, it is half merged into the second commit :().

WithXYZ() pattern functions better at making incremental changes without obtaining the original options object. While here you're building the Option all at once, so looks good to me.

alculquicondor
alculquicondor reviewed Mar 2, 2021
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to squash from my POV

pkg/scheduler/framework/plugins/feature/feature.go Outdated Show resolved Hide resolved
@ahg-g ahg-g force-pushed the ahg-nss branch 2 times, most recently from 97cdd8e to bfde6ce Compare March 3, 2021 15:02
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 3, 2021 •
edited

@ahg-g: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-bazel-test 13490a91fbc349cde1a5f170ccabbc2112b2dbef link /test pull-kubernetes-bazel-test
pull-kubernetes-e2e-azure-file c54fb24f314ce1a34657eee1f610307f56c950fb link /test pull-kubernetes-e2e-azure-file
pull-kubernetes-e2e-ubuntu-gce-network-policies c54fb24f314ce1a34657eee1f610307f56c950fb link /test pull-kubernetes-e2e-ubuntu-gce-network-policies
pull-kubernetes-conformance-image-test c54fb24f314ce1a34657eee1f610307f56c950fb link /test pull-kubernetes-conformance-image-test
pull-kubernetes-e2e-azure-disk-vmss c54fb24f314ce1a34657eee1f610307f56c950fb link /test pull-kubernetes-e2e-azure-disk-vmss
pull-kubernetes-e2e-gce-storage-slow c54fb24f314ce1a34657eee1f610307f56c950fb link /test pull-kubernetes-e2e-gce-storage-slow
pull-kubernetes-e2e-gce-csi-serial c54fb24f314ce1a34657eee1f610307f56c950fb link /test pull-kubernetes-e2e-gce-csi-serial
pull-kubernetes-e2e-azure-disk c54fb24f314ce1a34657eee1f610307f56c950fb link /test pull-kubernetes-e2e-azure-disk
pull-kubernetes-e2e-aks-engine-azure c54fb24f314ce1a34657eee1f610307f56c950fb link /test pull-kubernetes-e2e-aks-engine-azure
pull-kubernetes-e2e-azure-file-windows c54fb24f314ce1a34657eee1f610307f56c950fb link /test pull-kubernetes-e2e-azure-file-windows
pull-kubernetes-e2e-aks-engine-windows-contianerd-test-images c54fb24f314ce1a34657eee1f610307f56c950fb link /test pull-kubernetes-e2e-aks-engine-windows-contianerd-test-images
pull-kubernetes-e2e-azure-file-windows-containerd c54fb24f314ce1a34657eee1f610307f56c950fb link /test pull-kubernetes-e2e-azure-file-windows-containerd
pull-kubernetes-e2e-gce-storage-snapshot c54fb24f314ce1a34657eee1f610307f56c950fb link /test pull-kubernetes-e2e-gce-storage-snapshot
pull-kubernetes-files-remake c54fb24f314ce1a34657eee1f610307f56c950fb link /test pull-kubernetes-files-remake
pull-kubernetes-e2e-azure-disk-windows c54fb24f314ce1a34657eee1f610307f56c950fb link /test pull-kubernetes-e2e-azure-disk-windows
pull-kubernetes-e2e-gci-gce-ipvs c54fb24f314ce1a34657eee1f610307f56c950fb link /test pull-kubernetes-e2e-gci-gce-ipvs

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Huang-Wei
Copy link
Member

/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2021
@ahg-g
Copy link
Member Author

ahg-g commented Mar 4, 2021

/remove-sig api-machinery
/remove-sig apps
/remove-sig auth
/remove-sig testing

@k8s-ci-robot k8s-ci-robot removed sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 4, 2021
@ahg-g
Copy link
Member Author

ahg-g commented Mar 4, 2021

/remove-kind api-change

@k8s-ci-robot k8s-ci-robot removed the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Mar 4, 2021
@alculquicondor
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit 3a7d16d into kubernetes:master Mar 4, 2021
@damemi damemi mentioned this pull request Mar 23, 2021
Merged
@ahg-g ahg-g deleted the ahg-nss branch October 25, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soulxu soulxu soulxu left review comments

@alculquicondor alculquicondor alculquicondor left review comments

@Huang-Wei Huang-Wei Huang-Wei left review comments

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@chendave chendave Awaiting requested review from chendave

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ahg-g @fejta-bot @alculquicondor @k8s-ci-robot @Huang-Wei @soulxu