Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements CrossNamespacePodAffinity quota scope #98582

Merged
merged 1 commit into from Mar 4, 2021
Merged

Implements CrossNamespacePodAffinity quota scope #98582

merged 1 commit into from Mar 4, 2021

Conversation

ahg-g
Copy link
Member

@ahg-g ahg-g commented Jan 29, 2021 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Implements CrossNamespacePodAffinity quota scope

Which issue(s) this PR fixes:
Part of #97203

Special notes for your reviewer:

#98378 should merge first.

Does this PR introduce a user-facing change?:

1. PodAffinityTerm includes a namespaceSelector field to allow selecting eligible namespaces based on their labels. 
2. A new CrossNamespacePodAffinity quota scope API that allows restricting which namespaces allowed to use PodAffinityTerm with corss-namespace reference via namespaceSelector or namespaces fields.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Please use the following format for linking documentation:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-scheduling/2249-pod-affinity-namespace-selector

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 29, 2021
@ahg-g ahg-g mentioned this pull request Jan 29, 2021
Closed
@ahg-g
Copy link
Member Author

ahg-g commented Jan 29, 2021

/assign @liggitt @alculquicondor

@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@fedebongio
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Feb 2, 2021
@k8s-ci-robot k8s-ci-robot added area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 4, 2021
@alculquicondor
Copy link
Member

/sig auth

@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Feb 5, 2021
@alculquicondor
Copy link
Member

lgtm, but leaving the official one to sig-auth

@liggitt liggitt moved this from Changes requested to In progress in API Reviews Mar 3, 2021
liggitt
liggitt reviewed Mar 3, 2021
View reviewed changes
Copy link
Member

@liggitt liggitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

API and validation changes all look good, can squash in review commit. made one suggestion on the API doc.

staging/src/k8s.io/api/core/v1/types.go Outdated Show resolved Hide resolved
@liggitt liggitt moved this from In progress to API review completed, 1.21 in API Reviews Mar 3, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2021
@ahg-g ahg-g force-pushed the ahg-scope branch 2 times, most recently from 5674216 to 302b633 Compare March 3, 2021 15:48
@liggitt
Copy link
Member

liggitt commented Mar 3, 2021

pull-kubernetes-dependencies is a known failure unrelated to your PR that is being worked on

@liggitt
Copy link
Member

liggitt commented Mar 3, 2021

change looks good, though generated API docs will probably need updating as well

@ahg-g
Copy link
Member Author

ahg-g commented Mar 3, 2021

change looks good, though generated API docs will probably need updating as well

yup, done.

@liggitt
Copy link
Member

liggitt commented Mar 3, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahg-g
Copy link
Member Author

ahg-g commented Mar 3, 2021

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2021
@ahg-g
Copy link
Member Author

ahg-g commented Mar 3, 2021

/hold

need to resolve some conflicts

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2021
@ahg-g
Add CrossNamespacePodAffinity quota scope and PodAffinityTerm.Namespa…
3c5f018 
…ceSelector APIs, and CrossNamespacePodAffinity quota scope implementation.
@ahg-g
Copy link
Member Author

ahg-g commented Mar 4, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2021
@Huang-Wei
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2021
@ahg-g
Copy link
Member Author

ahg-g commented Mar 4, 2021

/retest

1 similar comment
@ahg-g
Copy link
Member Author

ahg-g commented Mar 4, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit e645472 into kubernetes:master Mar 4, 2021
@thejoycekung thejoycekung mentioned this pull request Mar 5, 2021
Closed
@ahg-g ahg-g deleted the ahg-scope branch October 25, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@alculquicondor alculquicondor alculquicondor left review comments

@Huang-Wei Huang-Wei Huang-Wei left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@liggitt liggitt

@alculquicondor alculquicondor

@Huang-Wei Huang-Wei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
Status: API review completed, 1.21
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@ahg-g @fejta-bot @fedebongio @alculquicondor @jpbetz @liggitt @k8s-ci-robot @Huang-Wei