Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move kubelet credential provider feature flag to beta and update the api's #108847

Merged
merged 1 commit into from Mar 25, 2022
Merged

Move kubelet credential provider feature flag to beta and update the api's #108847

merged 1 commit into from Mar 25, 2022

Conversation

adisky
Copy link
Contributor

@adisky adisky commented Mar 21, 2022 •
edited

Signed-off-by: Aditi Sharma adi.sky17@gmail.com

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

Move the Kubelet Credential Provider feature to Beta, Update the credential provider api to beta

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Kubelet external Credential Provider feature is moved to Beta.  Credential Provider Plugin and Credential Provider Config API's updated from v1alpha1 to v1beta1 with no API changes.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2133-kubelet-credential-providers

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 21, 2022
@adisky adisky force-pushed the update-credential-api branch 2 times, most recently from 6b0b5d4 to 12b10c5 Compare March 22, 2022 07:59
@k8s-ci-robot k8s-ci-robot added area/code-generation kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 22, 2022
@adisky adisky force-pushed the update-credential-api branch 3 times, most recently from 02e047c to f31a449 Compare March 22, 2022 11:45
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 22, 2022
@adisky adisky changed the title [WIP] Move kubelet credential provider feature flag to beta and update the api's Move kubelet credential provider feature flag to beta and update the api's Mar 22, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 22, 2022
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@ehashman
Copy link
Member

/priority important-soon
/triage accepted
/assign
/label api-review

@adisky
Copy link
Contributor Author

adisky commented Mar 24, 2022

/retest

@liggitt
Copy link
Member

liggitt commented Mar 24, 2022

/retest

/lgtm
/approve

@liggitt
Copy link
Member

liggitt commented Mar 24, 2022

update the release note with specifically what actions a user should take (e.g. credential provider config changed from apiVersion X to Y, with no other API changes)

@liggitt liggitt added this to API review completed, 1.24 in API Reviews Mar 24, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adisky, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2022
@adisky
Move feature flag credential provider to beta
ed16ef2 
Signed-off-by: Aditi Sharma <adi.sky17@gmail.com>
@liggitt
Copy link
Member

liggitt commented Mar 24, 2022

/lgtm
/hold cancel

@andrewsykim
Copy link
Member

/retest

@andrewsykim
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2022
@andrewsykim
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2022
@ehashman ehashman moved this from Needs Reviewer to Done in SIG Node PR Triage Mar 24, 2022
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@andrewsykim
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 68cf2a6 into kubernetes:master Mar 25, 2022
This was referenced Mar 25, 2022
Merged
Closed
@Priyankasaggu11929 Priyankasaggu11929 mentioned this pull request Mar 25, 2022
Closed
4 tasks
@tengqm tengqm mentioned this pull request Mar 29, 2022
Merged
mtaufen
mtaufen reviewed Jul 29, 2022
View reviewed changes
staging/src/k8s.io/kubelet/config/v1beta1/types.go

// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object

// CredentialProviderConfig is the configuration containing information about
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liggitt WDYT? Is it awkward that these are in kubelet/config/v1beta1 now that folks want to move them to GA? Is it possible to create kubelet/config/v1 with only support for the CredentialProviderConfig (I can't remember if that'll work or yell about being unable to round trip the non-GA stuff through available API versions)?

Copy link
Contributor

@mtaufen mtaufen Jul 29, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndixita was wondering the best path forward here for graduating CredentialProviderConfig et. al. without boiling the ocean of getting everything else in here to GA.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it awkward that these are in kubelet/config/v1beta1 now that folks want to move them to GA?

GA feature should correspond to GA config, yes

Is it possible to create kubelet/config/v1 with only support for the CredentialProviderConfig

Yes, sparse versions work fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtaufen mtaufen mtaufen left review comments

@liggitt liggitt liggitt left review comments

@andrewsykim andrewsykim andrewsykim left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@liggitt liggitt

@ehashman ehashman

@derekwaynecarr derekwaynecarr

@SergeyKanzhelev SergeyKanzhelev

@andrewsykim andrewsykim

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
Status: API review completed, 1.24
SIG Node PR Triage
Done
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@adisky @k8s-triage-robot @ehashman @andrewsykim @liggitt @k8s-ci-robot @mtaufen @derekwaynecarr @SergeyKanzhelev