test/e2e_node: update kubelet credential provider tests to use new v1beta1 APIs #109006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APIs Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
…ials to validate against v1beta1 kubelet APIs Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
approved
Need to add the presubmit job for the same, i have added periodic only for the first pass. Going to create PR for presubmit |
|
@andrewsykim Created PR for pre-submit job |
|
/test pull-kubernetes-node-kubelet-credential-provider |
|
@endocrimes: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-kubernetes-node-kubelet-credential-provider |
|
/retest |
|
/test pull-kubernetes-node-kubelet-credential-provider |
endocrimes
approved these changes
Mar 25, 2022
|
/lgtm |
|
/test pull-kubernetes-node-kubelet-credential-provider |
|
@ehashman: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ehashman
reviewed
Mar 25, 2022
k8s-ci-robot
added
priority/important-longterm
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewsykim, ehashman, endocrimes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
/hold cancel (we have post-submit CI so will monitor that once this is merged) |
|
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
|
/test pull-kubernetes-integration |
|
We are good here as the periodic job is passing after thismerge Will check the problem with pre submit jobs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Update the kubelet credential provider node e2e tests to use the new v1beta1 APIs that was recently added in #108847.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: