pkg/credentialprovider/plugin: refactor for better testability with mulitple apiVersions #109008
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
|
/assign @adisky |
k8s-ci-robot
added
do-not-merge/needs-sig
k8s-ci-robot
added
the
needs-priority
andrewsykim
changed the title
|
/test pr-kubelet-gce-e2e-credential-provider |
|
@adisky: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-kubernetes-node-kubelet-credential-provider |
|
@adisky: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-kubernetes-node-kubelet-credential-provider |
andrewsykim
force-pushed
the
kubelet-cred-provider-refactor-unit-tests
branch
from
28644d4
to
a106ab2
Compare
andrewsykim
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/sig node |
k8s-ci-robot
added
sig/node
k8s-ci-robot
added
triage/accepted
|
let's leave this for 1.25 (and we may just drop the v1alpha1 for 1.25) /milestone v1.25 |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
|
Hi @andrewsykim |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
k8s-ci-robot
added
lifecycle/rotten
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
|
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/reopen (coming back from a long break) I think at this point we'll want to remove the v1alpha1 APIs in v1.26, but I think this refactor is still worthwhile as we'll need to test both v1beta1 and v1 APIs. Working on a separate PR to remove v1alpha1 APIs. |
|
@andrewsykim: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: andrewsykim The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…lity Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
…to return json blobs Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
… mismatched from plugins Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
andrewsykim
force-pushed
the
kubelet-cred-provider-refactor-unit-tests
branch
from
a106ab2
to
5bd1080
Compare
|
/retest |
|
Taking a quick glance at that PR, I think it'll be easier to revisit this after #111616 merges (along with removing v1alpha1 APIs) |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
#108847 introduced the v1beta1 APIs for the kubelet credential provider feature. Although the v1beta1 APIs are preferred going forward and there are no changes between v1alpha1 and v1beta1, we should still have tests validating v1alpha1 as long as it's supported. This PR refactors the credential provider plugin so we can unit test against multiple apiVersions and test behavior when the apiVersions are mismatched. These unit tests should also help fill in v1alpha1 coverage we're losing with #109006, since the node e2e tests would only be running with v1beta1 APIs.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: