Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce APIs to support multiple ClusterCIDRs #108290

Merged
merged 4 commits into from Mar 31, 2022
Merged

Introduce APIs to support multiple ClusterCIDRs #108290

merged 4 commits into from Mar 31, 2022

Conversation

sarveshr7
Copy link
Contributor

@sarveshr7 sarveshr7 commented Feb 23, 2022 •
edited

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

This PR implements APIs from kubernetes/enhancements#2594

API Changes:

  • Introduces networking.k8s.io/v1alpha1 API group
  • Introduces ClusterCIDRConfig type in networking.k8s.io/v1alpha1 API group

Which issue(s) this PR fixes:

NONE

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Introduce a v1alpha1 networking API for ClusterCIDRConfig

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]:  https://github.com/kubernetes/enhancements/pull/2594

/sig network

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/network Categorizes an issue or PR as relevant to SIG Network. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 23, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @sarveshr7!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 23, 2022 •
edited

CLA Signed

The committers are authorized under a signed CLA.

  • ✅ Sarvesh Rangnekar (addc500ac991847d5c58b676813a206cc73aaf1e, 2656ce99143e7942b9f48c61511914a06508c2aa, 65228fd5dc3b0e884513e401f6e90e66c83fd32c, f7855b276ddc1c18634bcc8f987ea1f3a398c4d0, 76d409fe0289da5975167e040f21628be345569a)

@k8s-ci-robot
Copy link
Contributor

Hi @sarveshr7. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. area/apiserver area/kubectl area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 23, 2022
@aojea
Copy link
Member

aojea commented Feb 23, 2022

awesome
/cc

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 23, 2022
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

aojea
aojea reviewed Feb 23, 2022
View reviewed changes
pkg/apis/networking/types.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot merged commit b9792a9 into kubernetes:master Mar 31, 2022
SIG Auth Old automation moved this from Changes Requested to Closed / Done Mar 31, 2022
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 31, 2022
@sarveshr7 sarveshr7 mentioned this pull request Mar 31, 2022
Merged
@github-actions github-actions bot mentioned this pull request Apr 5, 2022
Open
@sftim
Copy link
Contributor

sftim commented Apr 11, 2022

It looks like a ClusterCIDRConfig API might have been added into v1.24? Is this new API part of v1.24 or not? (I'm asking because if it is part of the release, it would need documenting).

@sftim
Copy link
Contributor

sftim commented Apr 11, 2022

BTW @sarveshr7 the KEP link in the issue description should have been to kubernetes/enhancements#2593 (AIUI)

@JamesLaverack JamesLaverack mentioned this pull request Apr 12, 2022
Merged
JamesLaverack added a commit to JamesLaverack/kubernetes that referenced this pull request Apr 13, 2022
@JamesLaverack
Revert "Introduce APIs to support multiple ClusterCIDRs (kubernetes#1…
7d57d5c 
…08290)"

This reverts commit b9792a9.
k8s-ci-robot added a commit that referenced this pull request Apr 13, 2022
@k8s-ci-robot
Merge pull request #109436 from JamesLaverack/revert-108290
4cdeab4 
Revert "Introduce APIs to support multiple ClusterCIDRs (#108290)"
sarveshr7 added a commit to sarveshr7/enhancements that referenced this pull request Jun 15, 2022
@sarveshr7
Update the ClusterCIDRConfig API and examples
0bda22f 
Based on modifications suggested in the API PR associated with this KEP
kubernetes/kubernetes#108290

Update the KEP Milestones.
sarveshr7 added a commit to sarveshr7/enhancements that referenced this pull request Jun 16, 2022
@sarveshr7
Update the ClusterCIDRConfig API and examples
7243a9a 
Based on modifications suggested in the API PR associated with this KEP
kubernetes/kubernetes#108290

Update the KEP Milestones.
@sarveshr7 sarveshr7 mentioned this pull request Jun 16, 2022
Merged
sarveshr7 added a commit to sarveshr7/enhancements that referenced this pull request Jun 16, 2022
@sarveshr7
Update the ClusterCIDRConfig API and examples
9a30355 
Based on modifications suggested in the API PR associated with this KEP
kubernetes/kubernetes#108290

Update the KEP Milestones.
sarveshr7 added a commit to sarveshr7/enhancements that referenced this pull request Jun 21, 2022
@sarveshr7
Update the ClusterCIDRConfig API and examples
eb33dbc 
Based on modifications suggested in the API PR associated with this KEP
kubernetes/kubernetes#108290

Update the KEP Milestones.
@sarveshr7 sarveshr7 mentioned this pull request Jul 13, 2022
Closed
muyangren2 pushed a commit to muyangren2/kubernetes that referenced this pull request Jul 14, 2022
@sarveshr7 @muyangren2
Introduce APIs to support multiple ClusterCIDRs (kubernetes#108290)
1450e5f 
* Introduce networking/v1alpha1 api, ClusterCIDRConfig type

Introduce networking/v1alpha1 api group.

Add `ClusterCIDRConfig` type to networking/v1alpha1 api group, this type
will enable the NodeIPAM controller to support multiple ClusterCIDRs.

* Change ClusterCIDRConfig.NodeSelector type in api

* Fix review comments for API

* Update ClusterCIDRConfig API Spec

Introduce PerNodeHostBits field, remove PerNodeMaskSize
muyangren2 pushed a commit to muyangren2/kubernetes that referenced this pull request Jul 14, 2022
@JamesLaverack @muyangren2
Revert "Introduce APIs to support multiple ClusterCIDRs (kubernetes#1…
d76fbd5 
…08290)"

This reverts commit b9792a9.
@leilajal
Copy link
Contributor

/triage accepted

pacoxu pushed a commit to pacoxu/enhancements that referenced this pull request Oct 12, 2022
@sarveshr7 @pacoxu
Update the ClusterCIDRConfig API and examples
bacd59d 
Based on modifications suggested in the API PR associated with this KEP
kubernetes/kubernetes#108290

Update the KEP Milestones.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei bowei left review comments

@BenTheElder BenTheElder BenTheElder left review comments

@rahulkjoshi rahulkjoshi rahulkjoshi left review comments

@thockin thockin thockin left review comments

@aojea aojea aojea left review comments

@dgrisonnet dgrisonnet dgrisonnet left review comments

@jiahuif jiahuif jiahuif requested changes

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@jkaniuk jkaniuk Awaiting requested review from jkaniuk

@jprzychodzen jprzychodzen Awaiting requested review from jprzychodzen

@marseel marseel Awaiting requested review from marseel

Assignees

@thockin thockin

@khenidak khenidak

@leilajal leilajal

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/code-generation area/kubectl area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
SIG Auth Old
Closed / Done
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet