Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP:2593:Update ClusterCIDRConfig API, Test plan and Milestones #3402

Merged
merged 2 commits into from Jun 23, 2022
Merged

KEP:2593:Update ClusterCIDRConfig API, Test plan and Milestones #3402

merged 2 commits into from Jun 23, 2022

Conversation

sarveshr7
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 16, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @sarveshr7!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @sarveshr7. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 16, 2022
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/network Categorizes an issue or PR as relevant to SIG Network. labels Jun 16, 2022
@sarveshr7
Copy link
Contributor Author

/cc @rahulkjoshi

@k8s-ci-robot
Copy link
Contributor

@sarveshr7: GitHub didn't allow me to request PR reviews from the following users: rahulkjoshi.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @rahulkjoshi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Priyankasaggu11929
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 21, 2022
@Priyankasaggu11929 Priyankasaggu11929 mentioned this pull request Jun 21, 2022
Closed
8 tasks
@rahulkjoshi
Copy link
Contributor

/lgtm
/cc @aojea

@k8s-ci-robot k8s-ci-robot requested a review from aojea June 21, 2022 09:06
@k8s-ci-robot
Copy link
Contributor

@rahulkjoshi: changing LGTM is restricted to collaborators

In response to this:

/lgtm
/cc @aojea

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aojea
Copy link
Member

aojea commented Jun 21, 2022

/lgtm
/assign @thockin

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2022
@rahulkjoshi
Copy link
Contributor

@sarveshr7 Can you also update the Test Plan section to use the new Test Plan template

Mostly this should just involve renaming the sections.

@sarveshr7
Update the ClusterCIDRConfig API and examples
eb33dbc 
Based on modifications suggested in the API PR associated with this KEP
kubernetes/kubernetes#108290

Update the KEP Milestones.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2022
@sarveshr7 sarveshr7 changed the title KEP:2593:Update ClusterCIDRConfig API and milestones KEP:2593:Update ClusterCIDRConfig API, Test plan and Milestones Jun 21, 2022
@rahulkjoshi
Copy link
Contributor

/assign @wojtek-t

@rahulkjoshi
Copy link
Contributor

/unassign @wojtek-t

@aojea
Copy link
Member

aojea commented Jun 23, 2022

/unassign @wojtek-t

/assign @johnbelamaric

he is reviewing PRR these days

thockin
thockin reviewed Jun 23, 2022
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

For after KEP freeze: I think we should bring a few of the semantics and naming in this KEP and the Service CIDR KEP together - they should feel like they were designed together :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sarveshr7, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit 77b761c into kubernetes:master Jun 23, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@caseydavenport caseydavenport Awaiting requested review from caseydavenport

@aojea aojea Awaiting requested review from aojea

Assignees

@thockin thockin

@aojea aojea

@johnbelamaric johnbelamaric

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@sarveshr7 @k8s-ci-robot @Priyankasaggu11929 @rahulkjoshi @aojea @thockin @johnbelamaric @wojtek-t