New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Introduce APIs to support multiple ClusterCIDRs (#108290)" #109436
Conversation
@JamesLaverack: The provided milestone is not valid for this repository. Milestones in this repository: [ Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@JamesLaverack: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/milestone v1.24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
From a SIG Release perspective.
/retest-required |
D'oh, I meant /retest - sorry |
I don't have context on the PR being reverted, will defer to Tim on this one |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
I agree that reverting this is probably the right thing to do, I'll let @thockin give the approve though. |
Sigh. I'm a little grumpy about this but not enough to argue it against the decision of release folks. /lgtm |
CI failure is legitimate, need to regen openapi |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
3 similar comments
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
f978c97
to
f504d6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JamesLaverack, justaugustus, saschagrunert, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Refetch tags before you regen the openapi, your local tags are incorrectly including v1alpha1 flowcontrol APIs which are no long served in 1.24 |
f504d6e
to
7d57d5c
Compare
/lgtm |
@JamesLaverack: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This reverts commit b9792a9.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This change reverts #108290, see kubernetes/enhancements#2593 (comment) for further details.
API Changes:
Which issue(s) this PR fixes:
NONE
Special notes for your reviewer:
Please bring comments about the nature of this revert to the k/enhancements issue here: kubernetes/enhancements#2593 (comment)
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig network
/release-blocker
/priority critical-urgent
/milestone 1.24