Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logcheck update and golangci-lint integration #108159

Merged
merged 3 commits into from Mar 25, 2022
Merged

logcheck update and golangci-lint integration #108159

merged 3 commits into from Mar 25, 2022

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Feb 16, 2022 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The updated logcheck finds additional problems and thanks to the integration into golangci-lint runs more efficiently and correctly (didn't check staging before).

Which issue(s) this PR fixes:

Fixes #106746, #108854, #106276, #105841, kubernetes/klog#214

Special notes for your reviewer:

The lack of tagging for logcheck is tracked in kubernetes/klog#312

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 16, 2022
@pohly pohly mentioned this pull request Feb 16, 2022
Merged
@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/kubeadm area/kubectl area/kubelet sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 16, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 24, 2022
@serathius
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2022
@pohly
Copy link
Contributor Author

pohly commented Mar 24, 2022

/test pull-kubernetes-unit

@dims
Copy link
Member

dims commented Mar 24, 2022

/skip

@dims
Copy link
Member

dims commented Mar 24, 2022

/approve
/lgtm

/assign @liggitt

(needs root OWNERS approval)

@dims
Copy link
Member

dims commented Mar 24, 2022

/retest

1 similar comment
@pohly
Copy link
Contributor Author

pohly commented Mar 24, 2022

/retest

@pohly pohly mentioned this pull request Mar 24, 2022
Closed
@dims
Copy link
Member

dims commented Mar 24, 2022

/retest

(not sure if it helps!)

@pohly
Copy link
Contributor Author

pohly commented Mar 24, 2022

/retest

TestCheckRetryClosesBody flake.

@liggitt
Copy link
Member

liggitt commented Mar 24, 2022

fwiw, the flaky unit test is getting skipped in #108981 until we resolve the issue

had one low priority comment about a change to the config logging escaping/garbling the config file content - #108159 (comment) - won't block this PR on it, but I'm pretty sure that change makes that log line very unusable

@liggitt
Copy link
Member

liggitt commented Mar 24, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2022
@fedebongio
Copy link
Contributor

/remove-sig api-machinery
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 24, 2022
@pohly
Copy link
Contributor Author

pohly commented Mar 24, 2022

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 24, 2022 •
edited

@pohly: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-aks-engine-windows-containerd 59b4a702ffd66f41a0850994d52d1f916e7a6e81 link false /test pull-kubernetes-e2e-aks-engine-windows-containerd
pull-kubernetes-conformance-kind-ipv6-parallel 59b4a702ffd66f41a0850994d52d1f916e7a6e81 link false /test pull-kubernetes-conformance-kind-ipv6-parallel
pull-kubernetes-e2e-capz-azure-disk 59b4a702ffd66f41a0850994d52d1f916e7a6e81 link false /test pull-kubernetes-e2e-capz-azure-disk
pull-kubernetes-e2e-capz-conformance 59b4a702ffd66f41a0850994d52d1f916e7a6e81 link false /test pull-kubernetes-e2e-capz-conformance
pull-kubernetes-e2e-capz-azure-file-vmss 59b4a702ffd66f41a0850994d52d1f916e7a6e81 link false /test pull-kubernetes-e2e-capz-azure-file-vmss
pull-kubernetes-e2e-capz-azure-disk-vmss 59b4a702ffd66f41a0850994d52d1f916e7a6e81 link false /test pull-kubernetes-e2e-capz-azure-disk-vmss
pull-kubernetes-e2e-capz-azure-file 59b4a702ffd66f41a0850994d52d1f916e7a6e81 link false /test pull-kubernetes-e2e-capz-azure-file
pull-kubernetes-e2e-gce-iscsi 17e3c55 link false /test pull-kubernetes-e2e-gce-iscsi
pull-kubernetes-e2e-gce-iscsi-serial 17e3c55 link false /test pull-kubernetes-e2e-gce-iscsi-serial

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dims
Copy link
Member

dims commented Mar 24, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit d60df5b into kubernetes:master Mar 25, 2022
SIG Node PR Triage automation moved this from Waiting on Author to Done Mar 25, 2022
SIG Auth Old automation moved this from Needs Triage to Closed / Done Mar 25, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 25, 2022
@liggitt liggitt mentioned this pull request Mar 25, 2022
Closed
@liggitt liggitt mentioned this pull request Dec 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@serathius serathius serathius left review comments

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@brancz brancz Awaiting requested review from brancz

Assignees

@dims dims

@liggitt liggitt

@serathius serathius

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/kubeadm area/kubectl area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.
Projects
SIG Auth
Archived in project
SIG Node CI/Test Board
Archive-it
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Done
SIG Auth Old
Closed / Done
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

logcheck: not applied to packages under staging
7 participants
@pohly @fedebongio @leilajal @serathius @dims @liggitt @k8s-ci-robot