logcheck: should not return error if no Go files are present

[ehashman]

/kind bug

What steps did you take and what happened:

When running logcheck against a directory that contains no Go files, I get an error:

-: no Go files in /home/ehashman/src/k8s/_output/local/go/src/k8s.io/kubernetes/pkg/kubelet/volumemanager/reconciler/pods
logcheck: error during loading

What did you expect to happen:

I would expect a directory with no Go files to pass the linter.

Anything else you would like to add:

/cc @adisky
/priority important-longterm

[adisky]

/good-first-issue

[k8s-ci-robot]

@adisky:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[umangachapagain]

/assign

[serathius]

@ehashman is problem mitigated by running linter against parent directories? For example now we run against pkg/kubelet/... which covers pkg/kubelet/volumemanager/reconciler/pods. This way it skips directories without Go files.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[umangachapagain]

This issue blocks kubernetes/kubernetes/issues/102439 which is targeted for v1.22.

/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[MadhavJivrajani]

/remove-lifecycle stale

[daemon1024]

I would like to look into this 🤓 /assign

[RinkiyaKeDad]

/assign @daemon1024

[shiva1333]

Hey @daemon1024 can you please give us a rough estimate as in how much time it will require to come up with a fix for this?
I'd suggest you to go through review comments of #220, it will give you an idea about the expected fix.
This is important for kubernetes/kubernetes#103293, if you need any help please feel free to ping us on slack #wg-structured-logging

[shiva1333]

/priority important-soon

[shiva1333]

/remove-priority important-longterm

[daemon1024]

@shivanshu1333 I have went through the relevant discussions. I am currently in process of setting up and reproducing it. I will have a fix or some concrete update by the end of the week.
Thank You I will make sure to reach out if I face some issues.

[shiva1333]

That's awesome, thanks!

[daemon1024]

Hello, Apologies for the delay.

As pointed out in #220 (comment), we can't depend on analyzer main function since it directly exits. So we need our own validation logic.

From #220 (comment)

I suspect the best way to accomplish this may be to always return true if given a path that contains no Go files before starting the rest of the program logic. This would constitute input validation and is not the way the PR is currently written.

So I rewrote the logic in the PR more in line with what this comment suggested. Here's the link to the commit daemon1024@fe26f9b

The caveat here is that we will be loading packages twice.

The other way to handle the validation is, we walk through the directory to check if there are any go files present there or not.

Here's the commit daemon1024@71d4862 using file walk.

I understand sharing commits is not the right way to ask for review but I wanted to confirm which of the methods should I proceed with before raising a PR.

[adisky]

@daemon1024 Feel free to raise a PR, there is no harm in raising the PR

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[shiva1333]

/remove-lifecycle stale

[liggitt]

fixed by kubernetes/kubernetes#108159

/close

[k8s-ci-robot]

@liggitt: Closing this issue.

In response to this:

fixed by kubernetes/kubernetes#108159

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.