New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release strategy for logcheck #312
Comments
Jordan's preference is to move it to a separate repo. |
+1 from me (separate repo) |
I can help with this. We'd need to create a PR to https://github.com/kubernetes/org for the repo request. Are we fine with simply taking the current code and starting fresh in a new repo, that is, not preserving the commit history? /assign |
Let's preserve history. Git can do it and there is valuable information in the commit history that shouldn't get lost. I would to it with "git format-patch hack/tools/logcheck", mangling paths, and "git am". There are of course other options. |
FWIW, +1 from me for moving to a separate repo. |
What should be the name of the new repo? Just I can see pros and cons for both: simpler structure, shorter path and release process when using |
@pohly need to poke the sig-instrumentation leads i think as they will be the owner? |
@RinkiyaKeDad: can you drive this, including the discussion on #sig-instrumentation regarding the repo? |
Yup, I can take care of that! Will continue this discussion about the repo name there. |
/kind feature
Right now, logcheck doesn't get released "properly" (no tag, no release notes). Kubernetes imports it via the commit hash (https://github.com/kubernetes/kubernetes/blob/0ade4678a7ba527d22f6baa81034dea423267608/hack/tools/go.mod#L14).
We could:
hack/tools/v0.1.0
Describe the solution you'd like
According to the discussion in kubernetes/kubernetes#108725 (comment), a separate repo seems more appropriate. There is no technical reason why the tool is in klog and releases are easier when it is a stand-alone repo.
The text was updated successfully, but these errors were encountered: