Fix serialization of x-kubernetes-validations OpenAPI extension

[liggitt]

What type of PR is this?

/kind bug
/kind flake

What this PR does / why we need it:

Switches the openapi serialized extension for x-kubernetes-validations to use the external type with correct json tags. It was getting serialized incorrectly as [{"Message":"...", "Rule":"..."}]

Makes the jsonschemaprops -> openapi -> jsonschemaprops roundtrip test more strict

• fails decoding on unrecognized fields (would have caught DeepCopy of JSONSchemaProps doesn't deeply copy XValidations. #107954 (comment))
• seeds from the current time and increases fuzz iterations for better coverage (bugs crept in with a fixed seed and 20 iterations)

Fix OpenAPI serialization of the x-kubernetes-validations field

/cc @benluddy @sttts
/sig api-machinery

[k8s-ci-robot]

@liggitt: GitHub didn't allow me to request PR reviews from the following users: benluddy.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What type of PR is this?

/kind bug
/kind flake

What this PR does / why we need it:

Makes the jsonschemaprops -> openapi -> jsonschemaprops roundtrip test more strict

• fails decoding on unrecognized fields (would have caught DeepCopy of JSONSchemaProps doesn't deeply copy XValidations. #107954 (comment))
• seeds from the current time and increases fuzz iterations for better coverage (bugs crept in with a fixed seed and 20 iterations)

TODO: resolve what to do for the serialization of the structured XValidations rule which is using capital Rule and Message fields.

Fix OpenAPI serialization of the x-kubernetes-validations field

/cc @benluddy @sttts
/sig api-machinery

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[liggitt]

serialization issue seen here:

[liggitt@liggitt-macbookpro2 kubernetes]$ TEST_RAND_SEED=389141000 go test k8s.io/apiextensions-apiserver/pkg/apiserver/validation
--- FAIL: TestRoundTrip (0.00s)
    validation_test.go:63: using overridden seed: 389141000
    validation_test.go:105: [unknown field "not.patternProperties.彤Ž叩ǖ搥Õ軯夞ȗ@.x-kubernetes-validations[0].Message" unknown field "not.patternProperties.彤Ž叩ǖ搥Õ軯夞ȗ@.x-kubernetes-validations[0].Rule"]
FAIL
FAIL	k8s.io/apiextensions-apiserver/pkg/apiserver/validation	0.886s

[liggitt]

This is producing an unserializable extension:

kubernetes/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/validation/validation.go

Lines 257 to 259 in 9b09612

	if len(in.XValidations) != 0 {
	out.VendorExtensible.AddExtension("x-kubernetes-validations", in.XValidations)
	}

Because the referenced XValidations field doesn't set json tags on its rule and message fields.

Options:

1. add json tags to the internal XValidations Rule and Message fields... not great because this is an internal type
2. change ConvertJSONSchemaPropsWithPostProcess to use the v1 CRD types which are serializable
3. translate the XValidations field to a struct private to ConvertJSONSchemaPropsWithPostProcess that is serializable

My instinct is to go with option 2

[liggitt]

Options:

1. add json tags to the internal XValidations Rule and Message fields... not great because this is an internal type
2. change ConvertJSONSchemaPropsWithPostProcess to use the v1 CRD types which are serializable
3. translate the XValidations field to a struct private to ConvertJSONSchemaPropsWithPostProcess that is serializable

My instinct is to go with option 2

hmm... switching conversion entirely to use v1 schema types wreaks havoc with the handling of raw JSON values for defaults, etc

[liggitt]

I defined an internal->v1 conversion for the ValidationRules type, and use the v1 type when constructing a structural schema

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• staging/src/k8s.io/apiextensions-apiserver/OWNERS [liggitt]
• staging/src/k8s.io/apiextensions-apiserver/pkg/apis/OWNERS [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[leilajal]

/triage accepted

[k8s-triage-robot]

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

[benluddy]

/assign

[benluddy]

/lgtm

[k8s-ci-robot]

@benluddy: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[liggitt]

/assign @jpbetz
for org member lgtm

[liggitt]

/retest

[jpbetz]

/lgtm

Wow, I'm surprised we didn't notice this till now. Thanks for fixing!