DeepCopy of JSONSchemaProps doesn't deeply copy XValidations.

[benluddy]

Failure cluster 89c7abe10b4e83db5885

Error text:

=== RUN   TestRoundTrip
    roundtrip.go:136: starting group ""
    roundtrip.go:149: finished group ""
    roundtrip.go:136: starting group "apiextensions.k8s.io"
    roundtrip.go:255: 	round tripping to apiextensions.k8s.io/v1, Kind=CustomResourceDefinition v1.CustomResourceDefinition
    roundtrip.go:255: 	round tripping to apiextensions.k8s.io/v1beta1, Kind=CustomResourceDefinition v1beta1.CustomResourceDefinition
    roundtrip.go:255: 	round tripping to apiextensions.k8s.io/v1, Kind=CustomResourceDefinition v1.CustomResourceDefinition
    roundtrip.go:255: 	round tripping to apiextensions.k8s.io/v1beta1, Kind=CustomResourceDefinition v1beta1.CustomResourceDefinition
    roundtrip.go:255: 	round tripping to apiextensions.k8s.io/v1, Kind=CustomResourceDefinition v1.CustomResourceDefinition
    roundtrip.go:409: CustomResourceDefinition: fuzzing a copy altered the original, diff:   &apiextensions.CustomResourceDefinition{

          						XValidations: apiextensions.ValidationRules{
        - 							{Rule: "ɪI=ǯ剢鿠>璼ĨĊ:xx", Message: "腺嬑.ú^x"},
        + 							{Rule: "ɪI=ǯ剢鿠>璼ĨĊ:x", Message: "腺嬑.ú^"},
          						},

Recent failures:

2/4/2022, 5:54:09 AM ci-kubernetes-generate-make-test-count10
2/3/2022, 11:54:15 PM ci-kubernetes-generate-make-test-count10
2/3/2022, 5:54:03 PM ci-kubernetes-generate-make-test-count10
2/3/2022, 5:53:28 AM ci-kubernetes-generate-make-test-count10
2/2/2022, 11:51:28 AM ci-kubernetes-generate-make-test-count10

/kind failing-test
/kind bug
/sig api-machinery

[benluddy]

/assign

[liggitt]

hmm... latest run of the count10 job with this commit failed:

k8s.io/kubernetes/vendor/k8s.io/apiextensions-apiserver/pkg/apiserver/validation: TestRoundTrip

=== RUN   TestRoundTrip
    validation_test.go:50: seed: 3916589616287113937
    validation_test.go:95: 13: expected
        	&apiextensions.JSONSchemaProps{ID:"AůO画Ĝ}ɽŘ竄", Schema:"Ð", Ref:(*string)(0xc00047e650), Description:"棭榎ȒPɐƓR", Type:"", Nullable:true, Format:"¥Ǣ臄32枍Ê鎍r覝", Title:"æ飷", Default:(*apiextensions.JSON)(0xc00047e630), Maximum:(*float64)(nil), ExclusiveMaximum:false, Minimum:(*float64)(nil), ExclusiveMinimum:true, MaxLength:(*int64)(nil), MinLength:(*int64)(nil), Pattern:"ʤ:|;", MaxItems:(*int64)(nil), MinItems:(*int64)(nil), UniqueItems:false, MultipleOf:(*float64)(nil), Enum:[]apiextensions.JSON(nil), MaxProperties:(*int64)(nil), MinProperties:(*int64)(nil), Required:[]string(nil), Items:(*apiextensions.JSONSchemaPropsOrArray)(nil), AllOf:[]apiextensions.JSONSchemaProps(nil), OneOf:[]apiextensions.JSONSchemaProps(nil), AnyOf:[]apiextensions.JSONSchemaProps(nil), Not:(*apiextensions.JSONSchemaProps)(nil), Properties:map[string]apiextensions.JSONSchemaProps(nil), AdditionalProperties:(*apiextensions.JSONSchemaPropsOrBool)(nil), PatternProperties:map[string]apiextensions.JSONSchemaProps(nil), Dependencies:apiextensions.JSONSchemaDependencies(nil), AdditionalItems:(*apiextensions.JSONSchemaPropsOrBool)(nil), Definitions:apiextensions.JSONSchemaDefinitions(nil), ExternalDocs:(*apiextensions.ExternalDocumentation)(nil), Example:(*apiextensions.JSON)(0xc00047e640), XPreserveUnknownFields:(*bool)(nil), XEmbeddedResource:true, XIntOrString:true, XListMapKeys:[]string(nil), XListType:(*string)(nil), XMapType:(*string)(nil), XValidations:apiextensions.ValidationRules{apiextensions.ValidationRule{Rule:"v7愶u搱k]Ǖ\"ã", Message:"蘷夜 ƪ鱽Ó盶=D]"}}}, got 
        	&apiextensions.JSONSchemaProps{ID:"AůO画Ĝ}ɽŘ竄", Schema:"Ð", Ref:(*string)(0xc00047eaa0), Description:"棭榎ȒPɐƓR", Type:"", Nullable:true, Format:"¥Ǣ臄32枍Ê鎍r覝", Title:"æ飷", Default:(*apiextensions.JSON)(0xc00047ead0), Maximum:(*float64)(nil), ExclusiveMaximum:false, Minimum:(*float64)(nil), ExclusiveMinimum:true, MaxLength:(*int64)(nil), MinLength:(*int64)(nil), Pattern:"ʤ:|;", MaxItems:(*int64)(nil), MinItems:(*int64)(nil), UniqueItems:false, MultipleOf:(*float64)(nil), Enum:[]apiextensions.JSON(nil), MaxProperties:(*int64)(nil), MinProperties:(*int64)(nil), Required:[]string(nil), Items:(*apiextensions.JSONSchemaPropsOrArray)(nil), AllOf:[]apiextensions.JSONSchemaProps(nil), OneOf:[]apiextensions.JSONSchemaProps(nil), AnyOf:[]apiextensions.JSONSchemaProps(nil), Not:(*apiextensions.JSONSchemaProps)(nil), Properties:map[string]apiextensions.JSONSchemaProps(nil), AdditionalProperties:(*apiextensions.JSONSchemaPropsOrBool)(nil), PatternProperties:map[string]apiextensions.JSONSchemaProps(nil), Dependencies:apiextensions.JSONSchemaDependencies(nil), AdditionalItems:(*apiextensions.JSONSchemaPropsOrBool)(nil), Definitions:apiextensions.JSONSchemaDefinitions(nil), ExternalDocs:(*apiextensions.ExternalDocumentation)(nil), Example:(*apiextensions.JSON)(0xc00047eb00), XPreserveUnknownFields:(*bool)(nil), XEmbeddedResource:true, XIntOrString:true, XListMapKeys:[]string(nil), XListType:(*string)(nil), XMapType:(*string)(nil), XValidations:apiextensions.ValidationRules{apiextensions.ValidationRule{Rule:"", Message:""}}}
--- FAIL: TestRoundTrip (0.06s)

[benluddy]

Interesting, that's a different TestRoundTrip? 👀

[benluddy]

It seems to be getting lost here:

kubernetes/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/validation/validation_test.go

Line 84 in 66af4ec

if err := json.Unmarshal(openAPIJSON, external); err != nil {

[liggitt]

yeah... this is squirrely... that test is doing the following:

1. fuzzing internal types
2. converting them to an openapi struct (which populates the extension x-kubernetes-validations pointing to internal ValidationRule structs)
3. serializes that to openapi json (which serializes Rule and Message in upper-case because there are no json tags on that struct)
4. deserializes that to v1 JSONSchemaProps, which expects those fields to be rule and message

[liggitt]

I'll open another PR strengthening the test, and will tag in @sttts to figure out what the right thing to do here is

this is the first structured extension we're adding that had subfields where capitalization mattered... I'm not 100% sure what we're doing here (serializing the internal types) is correct

[liggitt]

PR in progress in #107970

[fedebongio]

/triage accepted