Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kubelet cri round trip test #107971

Merged
merged 1 commit into from Feb 7, 2022

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Feb 5, 2022

What type of PR is this?

/kind bug
/kind test

What this PR does / why we need it:

Fixes the kubelet cri memory-compatibility test to recurse properly

Found while working on a similar test for #107970

The test wasn't recursing into slices correctly (it was grabbing the type of each slice's element, then the type of the type (which is a reflect type), then asserting those were equal, which of course they were.

Once we started recursing correctly, two differences got flagged:

  • enum content of the protobuf struct tags, which is not relevant to the wire serialization and is expected to be difference since it refers to a package-qualified type
  • several unhandled type declarations that were aliases of int32... this adds handling for that case and asserts both sides are int32.

/cc @saschagrunert
/sig node

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Feb 5, 2022
@k8s-ci-robot
Copy link
Contributor

@liggitt: The label(s) kind/test cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind bug
/kind test

What this PR does / why we need it:

Fixes the kubelet cri memory-compatibility test to recurse properly

Found while working on a similar test for #107970

The test wasn't recursing into slices correctly (it was grabbing the type of each slice's element, then the type of the type (which is a reflect type), then asserting those were equal, which of course they were.

Once we started recursing correctly, two differences got flagged:

  • enum content of the protobuf struct tags, which is not relevant to the wire serialization and is expected to be difference since it refers to a package-qualified type
  • several unhandled type declarations that were aliases of int32... this adds handling for that case and asserts both sides are int32.

/cc @saschagrunert
/sig node

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 5, 2022
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm
/cc @ehashman

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 7, 2022
@saschagrunert
Copy link
Member

/test pull-kubernetes-e2e-kind-ipv6

@k8s-ci-robot k8s-ci-robot merged commit a266805 into kubernetes:master Feb 7, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 7, 2022
@liggitt liggitt deleted the kubelet-round-trip branch February 9, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants