New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kubelet cri round trip test #107971
Fix kubelet cri round trip test #107971
Conversation
@liggitt: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/cc @ehashman
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/triage accepted |
/test pull-kubernetes-e2e-kind-ipv6 |
What type of PR is this?
/kind bug
/kind test
What this PR does / why we need it:
Fixes the kubelet cri memory-compatibility test to recurse properly
Found while working on a similar test for #107970
The test wasn't recursing into slices correctly (it was grabbing the type of each slice's element, then the type of the type (which is a reflect type), then asserting those were equal, which of course they were.
Once we started recursing correctly, two differences got flagged:
enum
content of the protobuf struct tags, which is not relevant to the wire serialization and is expected to be difference since it refers to a package-qualified type/cc @saschagrunert
/sig node