Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote EphemeralContainers to beta #105405

Merged
merged 11 commits into from Oct 20, 2021
Merged

Promote EphemeralContainers to beta #105405

merged 11 commits into from Oct 20, 2021

Conversation

verb
Copy link
Contributor

@verb verb commented Oct 1, 2021 •
edited

What type of PR is this?

/kind feature
/sig node
/priority important-soon

What this PR does / why we need it:

This promotes KEP-277 to beta

Which issue(s) this PR fixes:

Fixes #98808

Special notes for your reviewer:

KEP Graduation Criteria:

PR TODO:

  • Add e2e test for volume mounts
  • Disallow subpath in ephemeral containers
  • Add validation of ephemeralContainerStatuses
  • Remove e2e test feature tags so that tests run unconditionally
  • Add test to ensure EphemeralContainerCommon field metadata remains in sync with Container
  • Explicitly document the behavior of container namespace targeting when runtime hasn't implemented support
  • Apply documentation style guide to API reference comments
  • Squash

Does this PR introduce a user-facing change?

Ephemeral containers have reached beta maturity and are now available by default.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: http://kep.k8s.io/277
- [Usage]: https://kubernetes.io/docs/tasks/debug-application-cluster/debug-running-pod/

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/node Categorizes an issue or PR as relevant to SIG Node. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 1, 2021
@verb
Copy link
Contributor Author

verb commented Oct 1, 2021

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 1, 2021
@verb verb mentioned this pull request Oct 1, 2021
Merged
@verb
Copy link
Contributor Author

verb commented Oct 1, 2021

This PR must be rebased after #103372 merges. Draft until then.

/test all

@ehashman ehashman added this to Waiting on Author in SIG Node PR Triage Oct 4, 2021
@verb verb mentioned this pull request Oct 5, 2021
Merged
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 5, 2021
@verb verb marked this pull request as ready for review October 5, 2021 13:55
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 5, 2021
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@verb
Copy link
Contributor Author

verb commented Oct 19, 2021 •
edited

Looks like the expanded e2e test is forbidding volumeDevices (I'll let msau weigh in on what should be done there), and there's an import alias failure

One question on the status validation from me, and a few nits, then the API bits lgtm.

👍 I think I've addressed all of these.

@msau42 I've added a commit to allow volumeDevices in ephemeral containers for now, because the API reference doesn't say that they're disallowed. I'm looking for guidance about whether they really should be allowed in ephemeral containers, though.

@msau42
Copy link
Member

msau42 commented Oct 20, 2021

I think it's fine for volumeDevices to be allowed. It's similar in scope to volumeMounts. Thanks so much for adding more tests! This is looking good from storage.

verb and others added 9 commits October 19, 2021 23:00
@verb
Validate ephemeralContainerStatuses during update
7648590
@verb
Clarify EphemeralContainer behavior in docs
26e183b 
- Apply doc style guide
- Specify behavior when namespace targeting isn't supported by runtime
@verb @liggitt
Add test for EphemeralContainerCommon struct tags
d1d7882 
The tags for type EphemeralContainerCommon should be kept in sync with
those of type Container.

Co-authored-by: Jordan Liggitt <liggitt@google.com>
@verb
Disallow subpath for ephemeral container mounts
f81c48c
@verb
Generated code for EphemeralContainers beta
b34e710
@verb
Add ephemeral container checks to volume e2e tests
ba649b9
@verb
Move ephemeral container e2e to common
40e7689
@verb
List disallowed ephemeral container fields
d874cf8 
Listing these explicitly makes it easier to determine whether a new
Container field has been evaluated for use with ephemeral containers.
This does not change the behavior of ephemeral containers.
@verb
Allow volumeDevices in ephemeral containers
d33bbb8
@verb verb changed the title WIP: Promote EphemeralContainers to beta Promote EphemeralContainers to beta Oct 20, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 20, 2021
@verb
Copy link
Contributor Author

verb commented Oct 20, 2021

/assign @dchen1107

@liggitt liggitt moved this from Changes requested to API review completed, 1.23 in API Reviews Oct 20, 2021
@liggitt
Copy link
Member

liggitt commented Oct 20, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, verb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2021
@dchen1107
Copy link
Member

/lgtm and thanks!

@k8s-ci-robot k8s-ci-robot merged commit 18104ec into kubernetes:master Oct 20, 2021
SIG Node CI/Test Board automation moved this from PRs - Needs Reviewer to Done Oct 20, 2021
SIG Node PR Triage automation moved this from Needs Reviewer to Done Oct 20, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 20, 2021
@tenzen-y tenzen-y mentioned this pull request Oct 29, 2021
Open
@verb verb deleted the 1.23-ec-beta branch November 11, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@sftim sftim sftim left review comments

@msau42 msau42 msau42 left review comments

@alejandrox1 alejandrox1 Awaiting requested review from alejandrox1

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@liggitt liggitt

@dchen1107 dchen1107

@msau42 msau42

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
Status: API review completed, 1.23
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Done
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

Promote Ephemeral Containers to beta and enable by default
8 participants
@verb @k8s-ci-robot @k8s-triage-robot @ehashman @liggitt @msau42 @dchen1107 @sftim