Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create node_e2e test for ephemeral containers #103372

Merged
merged 2 commits into from Oct 5, 2021
Merged

Create node_e2e test for ephemeral containers #103372

merged 2 commits into from Oct 5, 2021

Conversation

verb
Copy link
Contributor

@verb verb commented Jun 30, 2021

What type of PR is this?

/kind feature
/sig node

What this PR does / why we need it:

This adds an node e2e test for creating ephemeral containers.

Which issue(s) this PR fixes:

Fixes #85545

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: http://kep.k8s.io/277

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 30, 2021
@k8s-ci-robot k8s-ci-robot added area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 30, 2021
@ehashman ehashman added this to Triage in SIG Node PR Triage Jul 1, 2021
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to PRs - Needs Reviewer in SIG Node CI/Test Board Jul 8, 2021
@SergeyKanzhelev
Copy link
Member

/remove-kind feature
/kind cleanup
/priority backlog
/triage accepted

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 8, 2021
@SergeyKanzhelev
Copy link
Member

xref KEP: kubernetes/enhancements#277

@SergeyKanzhelev
Copy link
Member

/assign @cynepco3hahue

@verb
Copy link
Contributor Author

verb commented Aug 2, 2021

Hi @cynepco3hahue, will you have time to review this new test?

@cynepco3hahue
Copy link

@verb Sure, will take a look today.

cynepco3hahue
cynepco3hahue reviewed Aug 2, 2021
View reviewed changes
Copy link

@cynepco3hahue cynepco3hahue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@verb Do we have a separate job for this test or does the test run as part of some existing job?

test/e2e/framework/pod/resource.go Outdated Show resolved Hide resolved
test/e2e/framework/pod/wait.go Outdated Show resolved Hide resolved
test/e2e/framework/pods.go Outdated Show resolved Hide resolved
test/e2e/framework/pods.go Outdated Show resolved Hide resolved
@verb
Copy link
Contributor Author

verb commented Aug 3, 2021

@cynepco3hahue thanks for the review!

@verb Do we have a separate job for this test or does the test run as part of some existing job?

It runs with the alpha features test. Do you think we should include it elsewhere as well?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 22, 2021
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 22, 2021
@verb
Copy link
Contributor Author

verb commented Sep 30, 2021

@ehashman could you help me find an approver for this node e2e test? It had lgtm but lost it when I fixed a merge conflict. Thanks!

@dims
Copy link
Member

dims commented Oct 1, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, verb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2021
@dims
Copy link
Member

dims commented Oct 1, 2021

/retest

@verb
Copy link
Contributor Author

verb commented Oct 1, 2021

Hi @cynepco3hahue, this PR is approved now, but we lost your LGTM to resolve a merge conflict. Could you please take another look to see if it still looks good? Thanks!

@verb verb mentioned this pull request Oct 1, 2021
Merged
@verb
Copy link
Contributor Author

verb commented Oct 1, 2021

/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Oct 1, 2021
@verb verb mentioned this pull request Oct 1, 2021
Merged
15 tasks
@SergeyKanzhelev
Copy link
Member

/test pull-kubernetes-e2e-gce-alpha-features
/test pull-kubernetes-node-e2e-alpha

SergeyKanzhelev
SergeyKanzhelev reviewed Oct 1, 2021
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits. Also started test, to make sure it's ready for review. I'm curious if the timeout of one minute is sufficient in CI environment

test/e2e_node/ephemeral_containers_test.go Outdated Show resolved Hide resolved
test/e2e/framework/pod/resource.go Show resolved Hide resolved
test/e2e/framework/pods.go Outdated Show resolved Hide resolved
test/e2e/framework/pods.go Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 4, 2021 •
edited

@verb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-node-e2e-alpha da8ddb7 link true /test pull-kubernetes-node-e2e-alpha
pull-kubernetes-node-kubelet-serial da8ddb7 link false /test pull-kubernetes-node-kubelet-serial
pull-kubernetes-node-kubelet-serial-containerd da8ddb7 link false /test pull-kubernetes-node-kubelet-serial-containerd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@verb @SergeyKanzhelev
Apply suggestions from code review
2a82228 
Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
@verb
Copy link
Contributor Author

verb commented Oct 5, 2021

@SergeyKanzhelev @cynepco3hahue @ehashman Please help me meet sig-nodes soft deadline for feature graduation by giving an LGTM on this new e2e test that has been open since June, previously had LGTM, already has approval, and is blocking #105405. This PR should be safe to merge because it only modifies test/ and adds a test that's only run by Alpha CI tests.

@dims
Copy link
Member

dims commented Oct 5, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2021
@k8s-ci-robot k8s-ci-robot merged commit c5ad58d into kubernetes:master Oct 5, 2021
SIG Node CI/Test Board automation moved this from PRs - Needs Approver to Done Oct 5, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 5, 2021
This was referenced Oct 5, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cynepco3hahue cynepco3hahue cynepco3hahue left review comments

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev left review comments

@alejandrox1 alejandrox1 Awaiting requested review from alejandrox1

@krmayankk krmayankk Awaiting requested review from krmayankk

Assignees

@dims dims

@cblecker cblecker

@cynepco3hahue cynepco3hahue

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Triage
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

Create e2e tests for Ephemeral Containers
7 participants
@verb @SergeyKanzhelev @cynepco3hahue @pacoxu @dims @k8s-ci-robot @cblecker