Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote EphemeralContainers to beta in website #29871

Merged
merged 1 commit into from Nov 21, 2021
Merged

Promote EphemeralContainers to beta in website #29871

merged 1 commit into from Nov 21, 2021

Conversation

verb
Copy link
Contributor

@verb verb commented Sep 30, 2021 •
edited

@k8s-ci-robot k8s-ci-robot added this to the 1.23 milestone Sep 30, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 30, 2021
@netlify
Copy link

netlify bot commented Sep 30, 2021 •
edited

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: 771ee15

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6193c89e3000ce21972905b7

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 30, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Sep 30, 2021
sftim
sftim reviewed Sep 30, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Early review: make sure to also update https://kubernetes.io/docs/concepts/workloads/pods/ephemeral-containers/ in this PR.

@verb verb mentioned this pull request Sep 30, 2021
Closed
23 tasks
@verb
Copy link
Contributor Author

verb commented Oct 1, 2021

/assign

@jlbutler
Copy link
Contributor

/assign

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 16, 2021
@verb verb changed the title PLACEHOLDER: Promote EphemeralContainers to beta in website Promote EphemeralContainers to beta in website Nov 16, 2021
@verb verb marked this pull request as ready for review November 16, 2021 12:55
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 16, 2021
@verb
Copy link
Contributor Author

verb commented Nov 16, 2021

Ok, well maybe the netlify jobs will fix themselves.

In the meantime, these files still have reference to alpha:

@jlbutler Any idea how these pages are generated? It would save me some digging.

@sftim
Copy link
Contributor

sftim commented Nov 16, 2021

I manually triggered a retry. Your other options are:

  • force-push a different but equivalent commit
  • teach Prow how to trigger a rebuild on /retest then use that (trickier)

@jlbutler
Copy link
Contributor

/lgtm

It looks resolved to me, is anything else needed for this?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3ffa17813b8cea7d1a2fb8b010873f02038b70a3

@tengqm
Copy link
Contributor

tengqm commented Nov 21, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6e45595 into kubernetes:dev-1.23 Nov 21, 2021
@verb verb deleted the 1.23-ec-beta branch July 23, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@jimangel jimangel Awaiting requested review from jimangel

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@verb verb

@jlbutler jlbutler

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.23
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@verb @jlbutler @sftim @k8s-ci-robot @tengqm