Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide utility helpers for preserving internal annotations #4253

Merged
merged 1 commit into from Oct 29, 2021
Merged

provide utility helpers for preserving internal annotations #4253

merged 1 commit into from Oct 29, 2021

Conversation

natasha41575
Copy link
Contributor

@natasha41575 natasha41575 commented Oct 20, 2021 •
edited

Task 4 in #4024, implementing function spec v1.

This adds some helper functions for function authors to kyaml for preserving annotations with the prefix internal.config.kubernetes.io.

It should go in the same release as #4248 and #4249.

ALLOW_MODULE_SPAN

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 20, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2021
@natasha41575 natasha41575 mentioned this pull request Oct 20, 2021
Open
8 tasks
@natasha41575
Copy link
Contributor Author

/hold

Making sure everyone can get their review in before this is merged.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2021
@natasha41575 natasha41575 mentioned this pull request Oct 20, 2021
Merged
KnVerey
KnVerey reviewed Oct 25, 2021
View reviewed changes
kyaml/kio/kioutil/kioutil.go Outdated Show resolved Hide resolved
kyaml/kio/kioutil/kioutil.go Outdated Show resolved Hide resolved
kyaml/kio/kioutil/kioutil.go Outdated Show resolved Hide resolved
kyaml/kio/kioutil/kioutil.go Outdated Show resolved Hide resolved
kyaml/kio/kioutil/kioutil_test.go Outdated Show resolved Hide resolved
kyaml/kio/kioutil/kioutil_test.go Outdated Show resolved Hide resolved
@natasha41575 natasha41575 added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 26, 2021
@k8s-ci-robot
Copy link
Contributor

@natasha41575: This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mengqiy
mengqiy reviewed Oct 27, 2021
View reviewed changes
kyaml/kio/kioutil/kioutil.go Outdated Show resolved Hide resolved
kyaml/kio/kioutil/kioutil.go Outdated Show resolved Hide resolved
kyaml/kio/kioutil/kioutil.go Outdated Show resolved Hide resolved
kyaml/kio/kioutil/kioutil.go Outdated Show resolved Hide resolved
@natasha41575 natasha41575 force-pushed the resourceListSDKHelpers branch 2 times, most recently from b854cf4 to 52f0361 Compare October 28, 2021 23:46
@natasha41575
Copy link
Contributor Author

/retest

@natasha41575 natasha41575 force-pushed the resourceListSDKHelpers branch 2 times, most recently from 2ff38e5 to 89f36d8 Compare October 28, 2021 23:59
mengqiy
mengqiy approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@mengqiy mengqiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mengqiy, natasha41575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@natasha41575
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2021
@natasha41575 natasha41575 merged commit 71b978d into kubernetes-sigs:master Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mengqiy mengqiy mengqiy approved these changes

@KnVerey KnVerey Awaiting requested review from KnVerey

Assignees

@mengqiy mengqiy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@natasha41575 @k8s-ci-robot @mengqiy @KnVerey