kyaml should implement KRM Functions Spec v1

[frankfarzan]

Following changes are needed to adhere to Functions Spec v1:

• Migrate internal annotations:

  • config.k8s.io/id -> internal.config.kubernetes.io/id
  • config.kubernetes.io/path -> internal.config.kubernetes.io/path
  • config.kubernetes.io/index -> internal.config.kubernetes.io/index

  But we should be aware that this is a backwards incompatible change. Here are the migration steps using the path annotation as a concrete example:

  1. Update all orchestrators so they add both legacy and new annotation when reading files. A function may mutate the legacy annotation (existing functions) or the new annotation (future functions). When writing files, the orchestrator should consume both and reconcile things correctly.
  2. Update all functions we know of so that they use the new annotation.
  3. Some grace period for any other function to migrate
  4. Orchestrator drops support for legacy annotation.

• PR: Migrate index path id annotations #4190

• .results field of ResourceList has been standardized in v1. There are small changes between implementation in kyaml and the spec.

  • PR: [breaking] update results field of ResourceList to implement function spec v1 #4248

• Change the apiVersion of ResourceList: config.kubernetes.io/v1alpha1 -> config.kubernetes.io/v1

  • PR: bump ResourceList from v1alpha1 to v1 #4249

• Provide utility helpers in SDKs to preserve annotations with internal.config.kubernetes.io prefix.

  • PR: provide utility helpers for preserving internal annotations #4253

• kustomize should drop support for the legacy annotations

[natasha41575]

/assign

[natasha41575]

Working on this now

[natasha41575]

All tasks are completed, but I am going to leaving this issue open as a tracker to remind us to remove the deprecated legacy annotations.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[natasha41575]

/remove-lifecycle stale

We are planning to release tomorrow. After this release IMO we can remove the legacy annotations.

FYI @mengqiy @KnVerey

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[KnVerey]

/remove-lifecycle stale

We still need to remove the legacy annotations

[natasha41575]

We still need to remove the legacy annotations

+1

/help

[k8s-ci-robot]

@natasha41575:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

We still need to remove the legacy annotations

+1

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[natasha41575]

/lifecycle frozen

[natasha41575]

The only thing left to do is to remove the legacy annotations.

We no longer need:

• config.k8s.io/id
• config.kubernetes.io/path
• config.kubernetes.io/index

So the last thing left to do here is remove these from the code & all references to them. If tests fail after their removal (they shouldn't), we need to look into why.

[irvifa]

/assign

[varshaprasad96]

/assign