Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[breaking] update results field of ResourceList to implement function spec v1 #4248

Merged
merged 1 commit into from Oct 29, 2021
Merged

[breaking] update results field of ResourceList to implement function spec v1 #4248

merged 1 commit into from Oct 29, 2021

Conversation

natasha41575
Copy link
Contributor

@natasha41575 natasha41575 commented Oct 19, 2021 •
edited

Task 2 in #4024, implementing function spec v1.

There are small discrepancies between kyaml implementation and the current specification of the ResourceList.results field. This PR fixes that.

This may considered a backwards-incompatible change that requires a version bump for kyaml.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 19, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2021
@natasha41575
Copy link
Contributor Author

natasha41575 commented Oct 19, 2021 •
edited

/hold

This should be included in the same release as #4249.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 19, 2021
@natasha41575 natasha41575 force-pushed the resourceListResults branch 2 times, most recently from 16b72c0 to 9a4e941 Compare October 19, 2021 22:46
This was referenced Oct 19, 2021
Merged
Open
monopole
monopole approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@monopole monopole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2021
KnVerey
KnVerey reviewed Oct 20, 2021
View reviewed changes
kyaml/fn/framework/framework.go Outdated Show resolved Hide resolved
kyaml/fn/framework/result.go Outdated Show resolved Hide resolved
@natasha41575 natasha41575 mentioned this pull request Oct 20, 2021
Merged
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2021
KnVerey
KnVerey approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@KnVerey KnVerey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2021
mengqiy
mengqiy reviewed Oct 27, 2021
View reviewed changes
kyaml/fn/framework/framework.go Show resolved Hide resolved
kyaml/fn/framework/result.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2021
mengqiy
mengqiy approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@mengqiy mengqiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KnVerey, mengqiy, monopole, natasha41575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mengqiy
Copy link
Member

mengqiy commented Oct 29, 2021

The changes in this PR contains breaking changes. Is there a way to mark it in kustomize repo?

@natasha41575
Copy link
Contributor Author

The changes in this PR contains breaking changes. Is there a way to mark it in kustomize repo?

I can rename the PR to draw our attention to it. The release is a manual process, and recently we have been combing through the commits when determining whether to bump the versions of modules. It's not the best system though and is prone to human error, but essentially what will happen is we will look through the PRs that are part of the release and bump the version accordingly.

@KnVerey @monopole Let's try to remember that this PR means kyaml needs a version bump.

@natasha41575 natasha41575 changed the title update results field of ResourceList to implement function spec v1 [breaking] update results field of ResourceList to implement function spec v1 Oct 29, 2021
@natasha41575
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2021
@k8s-ci-robot
Copy link
Contributor

@natasha41575: This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2021
@mengqiy
Copy link
Member

mengqiy commented Oct 29, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4fd77b3 into kubernetes-sigs:master Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mengqiy mengqiy mengqiy approved these changes

@monopole monopole monopole approved these changes

@KnVerey KnVerey KnVerey approved these changes

Assignees

@mengqiy mengqiy

@monopole monopole

@KnVerey KnVerey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@natasha41575 @k8s-ci-robot @mengqiy @monopole @KnVerey