Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1beta2 API Changes #2355

Closed
4 tasks
richardcase opened this issue Apr 16, 2021 · 30 comments
Closed
4 tasks

v1beta2 API Changes #2355

richardcase opened this issue Apr 16, 2021 · 30 comments
Labels
area/provider/eks Issues or PRs related to Amazon EKS provider kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/refactor kind/release-blocking Issues or PRs that need to be closed before the next release priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
v2.0.0

Comments

@richardcase
Copy link
Member

richardcase commented Apr 16, 2021 •
edited

/kind refactor
/kind api-change
/area provider/eks
/priority important-soon
/milestone v0.7.0

Describe the solution you'd like
Refactor the API with the proposed changes for v1beta2/v1 including any field deprecations:

Changes:

Environment:

  • Cluster-api-provider-aws version: 0.6.5
@k8s-ci-robot k8s-ci-robot added this to the v0.7.0 milestone Apr 16, 2021
@k8s-ci-robot k8s-ci-robot added kind/refactor kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API area/provider/eks Issues or PRs related to Amazon EKS provider priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Apr 16, 2021
@richardcase
Copy link
Member Author

/assign

@randomvariable
Copy link
Member

/kind release-blocking

@k8s-ci-robot k8s-ci-robot added the kind/release-blocking Issues or PRs that need to be closed before the next release label Apr 16, 2021
@richardcase richardcase mentioned this issue Apr 22, 2021
Merged
@randomvariable randomvariable modified the milestones: v0.7.0, v0.7.x Jun 28, 2021
@richardcase
Copy link
Member Author

As this requires a change in contract we will have to wait for the next API bump (i.e. v1alpha5)

/milestone Next
/priority important-longterm

@k8s-ci-robot k8s-ci-robot modified the milestones: v0.7.x, Next Aug 23, 2021
@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Aug 23, 2021
@richardcase richardcase removed the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Aug 23, 2021
@richardcase richardcase changed the title Managed v1alpha4 API Changes Managed v1alpha5 API Changes Aug 23, 2021
@richardcase
Copy link
Member Author

/unassign

@sedefsavas sedefsavas removed this from the Next milestone Nov 1, 2021
@sedefsavas
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Nov 1, 2021
@randomvariable randomvariable changed the title Managed v1alpha5 API Changes Managed v1beta2 / v1 API Changes Nov 8, 2021
@randomvariable
Copy link
Member

/milestone backlog

@k8s-ci-robot
Copy link
Contributor

@randomvariable: The provided milestone is not valid for this repository. Milestones in this repository: [Backlog, v0.6.x, v0.7.0, v0.7.x, v1.0.x, v1.1.0, v1.x]

Use /milestone clear to clear the milestone.

In response to this:

/milestone backlog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 6, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 8, 2022
@richardcase
Copy link
Member Author

Fix the typo in #3467

@sedefsavas sedefsavas mentioned this issue Jun 13, 2022
Merged
4 tasks
@sedefsavas
Copy link
Contributor

Adding CCM tags to route tables and SGs:
#3532
#3481

@richardcase
Copy link
Member Author

Make sure we don't miss: #3526

@pydctw pydctw mentioned this issue Jul 7, 2022
Closed
4 tasks
@richardcase
Copy link
Member Author

/remove-lifecycle frozen

@k8s-ci-robot k8s-ci-robot removed the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jul 12, 2022
@richardcase
Copy link
Member Author

Change the addons override to default to overwrite: #3513 (comment)

@pydctw
Copy link
Contributor

pydctw commented Jul 27, 2022 •
edited

Top-level issue for Adopting CAPI's Server Side Apply to support ClusterClass

Specific Issues that require v1beta2 API

@sedefsavas
Copy link
Contributor

Remove deviceName from rootVolume in AWSMachinePool CR: #3624

@sedefsavas
Copy link
Contributor

NLB support: #3088
with uniques NLB names: #969

@sedefsavas sedefsavas changed the title v1beta2 / v1 API Changes v1beta2 API Changes Jul 28, 2022
@sedefsavas
Copy link
Contributor

Internet-facing LB scheme clean up:
#3673

@richardcase richardcase mentioned this issue Aug 22, 2022
Merged
4 tasks
@sedefsavas
Copy link
Contributor

Move SSH key validation out of API types:
#3720 (comment)

@sedefsavas sedefsavas mentioned this issue Sep 15, 2022
Merged
4 tasks
@richardcase richardcase mentioned this issue Sep 20, 2022
Open
@sedefsavas
Copy link
Contributor

This might need API change as well:
kubernetes-sigs/cluster-api#6412
cc @dlipovetsky

@richardcase
Copy link
Member Author

/milestone v2.0.0

@k8s-ci-robot k8s-ci-robot added this to the v2.0.0 milestone Nov 8, 2022
@richardcase
Copy link
Member Author

We need to review the items on this and see what we need to get in and what can be moved to v1beta3

@Ankitasw Ankitasw mentioned this issue Nov 9, 2022
Merged
4 tasks
@Ankitasw
Copy link
Member

Ankitasw commented Nov 9, 2022

AWSManagedMachinePool field deprecations as a result of #3094 can be moved to next API version.

This was referenced Nov 11, 2022
Merged
Merged
Merged
@richardcase richardcase mentioned this issue Nov 15, 2022
Open
2 tasks
@Ankitasw
Copy link
Member

/close

@k8s-ci-robot
Copy link
Contributor

@Ankitasw: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/provider/eks Issues or PRs related to Amazon EKS provider kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/refactor kind/release-blocking Issues or PRs that need to be closed before the next release priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
7 participants
@richardcase @randomvariable @k8s-ci-robot @pydctw @k8s-triage-robot @sedefsavas @Ankitasw