Relax the AWSManagedControlPlane version regex and remove normalising the version

[Skarlso]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Removes the normalisation we perform for the version given to the AWSManagedControlPlane object. EKS requires a major.minor version format and we did that by truncating any given version and having a regex validation for the version being major.minor.

This, however, lead to us editing the spec and causing diff in applied / existing configs.

This PR attempts to remove this normalisation and relax the regex, so existing configurations don't break ( normally they would break, because we no longer truncate a given version ).

However, everywhere internally where we DO use the version for various things like creating a cluster, it should already be normalised.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3594.

Special notes for your reviewer:

Checklist:

• squashed commits
• includes documentation
• adds unit tests
• adds or updates e2e tests

[k8s-ci-robot]

@Skarlso: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Skarlso]

/ok-to-test

[Skarlso]

/test pull-cluster-api-provider-aws-e2e-eks

[Ankitasw]

/ok-to-test

@Skarlso Since you a member of kubernetes-sigs, there is no need for the ok-to-test label, your changes would be tested automatically.

[Skarlso]

@Ankitasw Ah! Okay, thank you! :) I thought it's always required. :D Cheers. :)

[richardcase]

This will need to go into v1beta2 as its a change to the API (i.e. the format/validation).

Tagging in #2355 so that we know this is linked to api changes.

[richardcase]

Although thinking about it the regex is backwards compatible so if someone already has v1.22 thats fine. And new clusters can additional use the v1.22.2 format.

[Skarlso]

Although thinking about it the regex is backwards compatible so if someone already has v1.22 thats fine. And new clusters can additional use the v1.22.2 format.

Yep :nod:.

[richardcase]

/lgtm

[richardcase]

I'll leave this to @sedefsavas to approve:

/assign sedefsavas

[richardcase]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [richardcase]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment