Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove failure domain from AWSMachineSpec to respect CAPI's Machine/MD failure domain field #3847

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Remove failure domain from AWSMachineSpec to respect CAPI's Machine/MD failure domain field #3847

merged 1 commit into from
Nov 15, 2022

Conversation

Ankitasw
Copy link
Member

@Ankitasw Ankitasw commented Nov 11, 2022 •
edited

What type of PR is this?
/kind cleanup
/kind api-change

What this PR does / why we need it:
This PR removes the failure domain field from AWSMachineSpec to respect CAPI's Machine/MD's failure domain field.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes Part of #2355

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Nov 11, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 11, 2022
@Ankitasw
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2022
@Ankitasw Ankitasw changed the title Remove failure domain from AWSMachineSpec to respect CAPI's Machine/MD failure domain field [WIP] Remove failure domain from AWSMachineSpec to respect CAPI's Machine/MD failure domain field Nov 11, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2022
@Ankitasw Ankitasw force-pushed the remove-failure-domain branch 4 times, most recently from c0ef94a to 8aaf4c0 Compare November 11, 2022 09:43
@Ankitasw
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e

@Ankitasw Ankitasw force-pushed the remove-failure-domain branch 4 times, most recently from 2d45872 to 6e8515b Compare November 11, 2022 15:46
@Ankitasw Ankitasw changed the title [WIP] Remove failure domain from AWSMachineSpec to respect CAPI's Machine/MD failure domain field Remove failure domain from AWSMachineSpec to respect CAPI's Machine/MD failure domain field Nov 11, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2022
@Ankitasw
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e-clusterclass
/test pull-cluster-api-provider-aws-e2e

@AverageMarcus
Copy link
Member

Looks like this has accidentally pulled in the changes made in #3835 also. Other than that looks good.

@Ankitasw
Copy link
Member Author

Ankitasw commented Nov 11, 2022 •
edited

Looks like this has accidentally pulled in the changes made in #3835 also. Other than that looks good.

Yes, it was intentional such that first #3835 gets merged, as this and #3835 has lot of code in common, thats why this is on hold, but open for review 😄

@AverageMarcus
Copy link
Member

Ah! I missed the hold.

@richardcase
Copy link
Member

/test ?

@k8s-ci-robot
Copy link
Contributor

@richardcase: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-test
  • /test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-aws-apidiff-main
  • /test pull-cluster-api-provider-aws-e2e
  • /test pull-cluster-api-provider-aws-e2e-blocking
  • /test pull-cluster-api-provider-aws-e2e-clusterclass
  • /test pull-cluster-api-provider-aws-e2e-conformance
  • /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
  • /test pull-cluster-api-provider-aws-e2e-eks

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-aws-apidiff-main
  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-test
  • pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@richardcase
Copy link
Member

/test pull-cluster-api-provider-aws-e2e-eks

richardcase
richardcase reviewed Nov 14, 2022
View reviewed changes
Copy link
Member

@richardcase richardcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One comment on the roundtrip fuzzing test.

Once the ARN change merges lets rebase this so we get rid of the ARN changes.

api/v1beta1/conversion_test.go Show resolved Hide resolved
@richardcase
Copy link
Member

/test pull-cluster-api-provider-aws-e2e-eks

@Ankitasw
Copy link
Member Author

cc @richardcase @Skarlso @AverageMarcus for final review.
Tests are passing locally so retriggered now.

@AverageMarcus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2022
@Skarlso
Copy link
Contributor

Skarlso commented Nov 15, 2022

/approve
/hold
until e2e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Skarlso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2022
@Ankitasw
Copy link
Member Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2022
@k8s-ci-robot k8s-ci-robot merged commit f5332d7 into kubernetes-sigs:main Nov 15, 2022
@Ankitasw Ankitasw deleted the remove-failure-domain branch November 15, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardcase richardcase richardcase left review comments

@dlipovetsky dlipovetsky Awaiting requested review from dlipovetsky

@dthorsen dthorsen Awaiting requested review from dthorsen

Assignees

@AverageMarcus AverageMarcus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ankitasw @AverageMarcus @richardcase @k8s-ci-robot @Skarlso