Remove ARN field from AWSResourceReference #3835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
kind/cleanup
k8s-ci-robot
added
cncf-cla: yes
|
/milestone v2.0.0 |
Ankitasw
force-pushed
the
remove-ARN-field
branch
2 times, most recently
from
bc74b61
to
d6dc94f
Compare
|
/test pull-cluster-api-provider-aws-e2e-blocking |
Ankitasw
changed the title
Ankitasw
force-pushed
the
remove-ARN-field
branch
from
d6dc94f
to
c2ea23e
Compare
Ankitasw
changed the title
Ankitasw
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
Ankitasw
force-pushed
the
remove-ARN-field
branch
2 times, most recently
from
0f5bf77
to
1505c2c
Compare
Ankitasw
commented
Nov 9, 2022
|
/test pull-cluster-api-provider-aws-e2e |
Ankitasw
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/test pull-cluster-api-provider-aws-e2e-eks |
|
/retest |
Ankitasw
force-pushed
the
remove-ARN-field
branch
from
1505c2c
to
9aea4e5
Compare
k8s-ci-robot
added
size/XL
|
/test pull-cluster-api-provider-aws-e2e |
|
Would split into small PRs so that things which are passing can merge soon |
Merged
4 tasks
k8s-ci-robot
added
the
lgtm
|
Non-eks e2e is passing. Lets check the eks side: /test pull-cluster-api-provider-aws-e2e-eks |
|
We can ignore the API diff error in this instances as we are deliberatrly breaking the contract (but we have conversions): /override pull-cluster-api-provider-aws-apidiff-main |
|
@richardcase: Overrode contexts on behalf of richardcase: pull-cluster-api-provider-aws-apidiff-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Didn't know we have this superpower 😄 |
|
cc @richardcase |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardcase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
bryan-cox
added a commit
to bryan-cox/hypershift
that referenced
this pull request
Dec 22, 2022
Removed ARN from the AWS machine template generation. This field was previously optional and was dropped from the CAPA spec in kubernetes-sigs/cluster-api-provider-aws#3835. Signed-off-by: Bryan Cox <brcox@redhat.com>
bryan-cox
added a commit
to bryan-cox/hypershift
that referenced
this pull request
Dec 22, 2022
Removed ARN from the AWS machine template generation. This field was previously optional and was dropped from the CAPA spec in kubernetes-sigs/cluster-api-provider-aws#3835. Signed-off-by: Bryan Cox <brcox@redhat.com>
bryan-cox
added a commit
to bryan-cox/hypershift
that referenced
this pull request
Dec 22, 2022
Removed ARN from the AWS machine template generation. This field was previously optional and was dropped from the CAPA spec in kubernetes-sigs/cluster-api-provider-aws#3835. Signed-off-by: Bryan Cox <brcox@redhat.com>
bryan-cox
added a commit
to bryan-cox/hypershift
that referenced
this pull request
Dec 22, 2022
Removed ARN from the AWS machine template generation. This field was previously optional and was dropped from the CAPA spec in kubernetes-sigs/cluster-api-provider-aws#3835. Signed-off-by: Bryan Cox <brcox@redhat.com>
bryan-cox
added a commit
to bryan-cox/hypershift
that referenced
this pull request
Jan 4, 2023
Removed ARN from the AWS machine template generation. This field was previously optional and was dropped from the CAPA spec in kubernetes-sigs/cluster-api-provider-aws#3835. Signed-off-by: Bryan Cox <brcox@redhat.com>
bryan-cox
added a commit
to bryan-cox/hypershift
that referenced
this pull request
Jan 4, 2023
Removed ARN from the AWS machine template generation. This field was previously optional and was dropped from the CAPA spec in kubernetes-sigs/cluster-api-provider-aws#3835. Signed-off-by: Bryan Cox <brcox@redhat.com>
bryan-cox
added a commit
to bryan-cox/hypershift
that referenced
this pull request
Jan 4, 2023
Removed ARN from the AWS machine template generation. This field was previously optional and was dropped from the CAPA spec in kubernetes-sigs/cluster-api-provider-aws#3835. Signed-off-by: Bryan Cox <brcox@redhat.com>
bryan-cox
added a commit
to bryan-cox/hypershift
that referenced
this pull request
Jan 5, 2023
Removed ARN from the AWS machine template generation. This field was previously optional and was dropped from the CAPA spec in kubernetes-sigs/cluster-api-provider-aws#3835. Signed-off-by: Bryan Cox <brcox@redhat.com>
bryan-cox
added a commit
to bryan-cox/hypershift
that referenced
this pull request
Jan 5, 2023
Removed ARN from the AWS machine template generation. This field was previously optional and was dropped from the CAPA spec in kubernetes-sigs/cluster-api-provider-aws#3835. Signed-off-by: Bryan Cox <brcox@redhat.com>
bryan-cox
added a commit
to bryan-cox/hypershift
that referenced
this pull request
Jan 5, 2023
Removed ARN from the AWS machine template generation. This field was previously optional and was dropped from the CAPA spec in kubernetes-sigs/cluster-api-provider-aws#3835. Signed-off-by: Bryan Cox <brcox@redhat.com>
bryan-cox
added a commit
to bryan-cox/hypershift
that referenced
this pull request
Jan 10, 2023
Removed ARN from the AWS machine template generation. This field was previously optional and was dropped from the CAPA spec in kubernetes-sigs/cluster-api-provider-aws#3835. Signed-off-by: Bryan Cox <brcox@redhat.com>
bryan-cox
added a commit
to bryan-cox/hypershift
that referenced
this pull request
Jan 10, 2023
Removed ARN from the AWS machine template generation. This field was previously optional and was dropped from the CAPA spec in kubernetes-sigs/cluster-api-provider-aws#3835. Signed-off-by: Bryan Cox <brcox@redhat.com>
bryan-cox
added a commit
to bryan-cox/hypershift
that referenced
this pull request
Jan 17, 2023
Removed ARN from the AWS machine template generation. This field was previously optional and was dropped from the CAPA spec in kubernetes-sigs/cluster-api-provider-aws#3835. Signed-off-by: Bryan Cox <brcox@redhat.com>
bryan-cox
added a commit
to bryan-cox/hypershift
that referenced
this pull request
Jan 17, 2023
Removed ARN from the AWS machine template generation. This field was previously optional and was dropped from the CAPA spec in kubernetes-sigs/cluster-api-provider-aws#3835. Signed-off-by: Bryan Cox <brcox@redhat.com>
bryan-cox
added a commit
to bryan-cox/hypershift
that referenced
this pull request
Jan 17, 2023
Removed ARN from the AWS machine template generation. This field was previously optional and was dropped from the CAPA spec in kubernetes-sigs/cluster-api-provider-aws#3835. Signed-off-by: Bryan Cox <brcox@redhat.com>
muraee
pushed a commit
to muraee/hypershift
that referenced
this pull request
Feb 6, 2023
Removed ARN from the AWS machine template generation. This field was previously optional and was dropped from the CAPA spec in kubernetes-sigs/cluster-api-provider-aws#3835. Signed-off-by: Bryan Cox <brcox@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
We deprecated ARN field from AWSResourceReference in this PR and decided to remove it once v1beta2 API changes are in. This PR removes that field.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes Part of #2355
Special notes for your reviewer:
Checklist: