Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: avert tar error in lint action #516

Merged
merged 1 commit into from Sep 9, 2021
Merged

ci: avert tar error in lint action #516

merged 1 commit into from Sep 9, 2021

Conversation

lkingland
Copy link
Member

Changes

  • 🐛 fix CI error in the Go Lint step of the Lint action.

This is a workaround to an open issue in golangci-lint-action.

An example of the error:

Error: /usr/bin/tar: ../../../go/pkg/mod/github.com/client9/misspell@v0.3.4/legal.go: Cannot open: File exists
Warning: Tar failed with error: The process '/usr/bin/tar' failed with exit code 2

/kind bug

@knative-prow-robot knative-prow-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 9, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 9, 2021
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 9, 2021
@lkingland lkingland requested a review from lance September 9, 2021 06:37
@lkingland lkingland assigned lkingland and unassigned lkingland Sep 9, 2021
This was referenced Sep 9, 2021
Merged
Merged
@lance
Copy link
Member

lance commented Sep 9, 2021

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2021
@knative-prow-robot knative-prow-robot merged commit 1125c53 into knative:main Sep 9, 2021
@lkingland lkingland deleted the knative-actions-linter-fix branch September 20, 2022 00:59
jrangelramos added a commit to jrangelramos/func that referenced this pull request Apr 25, 2023
@jrangelramos
chore: patch func-deploy task to midstream specific impletementation …
4b8dd7c 
…with serverless 1.28 kn client image (knative#516)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance lance Awaiting requested review from lance

Assignees

@lance lance

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lkingland @knative-prow-robot @lance