Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: repository management cli #514

Merged
merged 2 commits into from
Sep 9, 2021
Merged

feat: repository management cli #514

merged 2 commits into from
Sep 9, 2021

Conversation

lkingland
Copy link
Member

@lkingland lkingland commented Sep 8, 2021 •
edited

Changes

  • 馃巵 repository management cli

/kind enhancement

Fixes #454

@knative-prow-robot knative-prow-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/enhancement labels Sep 8, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 8, 2021
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 8, 2021
lkingland
lkingland commented Sep 8, 2021
View reviewed changes
client.go Show resolved Hide resolved
@lkingland lkingland marked this pull request as ready for review September 8, 2021 10:09
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 8, 2021
@lkingland lkingland mentioned this pull request Sep 8, 2021
Closed
lance
lance reviewed Sep 8, 2021
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - small small wording suggestions and other nits

repository.go Outdated Show resolved Hide resolved
cmd/repository.go Outdated Show resolved Hide resolved
cmd/repository.go Outdated Show resolved Hide resolved
cmd/repository.go Outdated Show resolved Hide resolved
cmd/repository.go Outdated Show resolved Hide resolved
cmd/repository.go Outdated Show resolved Hide resolved
cmd/repository.go Outdated Show resolved Hide resolved
cmd/repository.go Show resolved Hide resolved
@lkingland
Copy link
Member Author

lkingland commented Sep 9, 2021 •
edited

Looks great - small small wording suggestions and other nits

Thanks so much @lance for taking the time to read and point out the errors. My eyes started to glaze over after too long on this PR... not useful when trying to self-proof. All suggestions were applied, along with their corollaries in commands.md. I amended and forced-updated to avoid the GoogBot complaining.

@lkingland lkingland requested a review from lance September 9, 2021 02:46
@lkingland lkingland force-pushed the repository-management-cli branch 2 times, most recently from ccc2c95 to b549b05 Compare September 9, 2021 04:50
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 9, 2021
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 9, 2021
@lkingland
Copy link
Member Author

CI Fixed in #516 and will rebase this and re-request /lgtm when merged.

@lance
Copy link
Member

lance commented Sep 9, 2021

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2021
@knative-prow-robot knative-prow-robot merged commit ae638c3 into knative:main Sep 9, 2021
@lkingland lkingland deleted the repository-management-cli branch September 20, 2022 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik left review comments

@lance lance Awaiting requested review from lance

Assignees

@lance lance

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide CLI based global management of language pack repositories
4 participants
@lkingland @knative-prow-robot @lance @zroubalik