Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: client effective runtimes list #490

Merged
merged 5 commits into from
Sep 9, 2021
Merged

feat: client effective runtimes list #490

merged 5 commits into from
Sep 9, 2021

Conversation

lkingland
Copy link
Member

@lkingland lkingland commented Aug 23, 2021 •
edited

Changes

  • 馃巵 Adds effective runtimes list to client API

Prerequisite for #451

/kind enhancement

@knative-prow-robot knative-prow-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/enhancement approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 23, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 23, 2021
@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 23, 2021
@lkingland lkingland self-assigned this Aug 23, 2021
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 24, 2021
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 25, 2021
@lkingland lkingland marked this pull request as ready for review August 25, 2021 08:34
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 25, 2021
matejvasek
matejvasek reviewed Aug 25, 2021
View reviewed changes
repositories_test.go Outdated Show resolved Hide resolved
matejvasek
matejvasek reviewed Aug 25, 2021
View reviewed changes
repositories_test.go Outdated Show resolved Hide resolved
lance
lance reviewed Aug 25, 2021
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from the two typos Matej pointed at.

/approve

repositories_test.go Outdated Show resolved Hide resolved
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 30, 2021
@lance lance mentioned this pull request Aug 31, 2021
Closed
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 9, 2021
@lkingland
Copy link
Member Author

CI Fixed in #516 and will rebase this and re-request /lgtm when merged.

@lkingland lkingland requested a review from lance September 9, 2021 14:07
@lance
Copy link
Member

lance commented Sep 9, 2021

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2021
@knative-prow-robot knative-prow-robot merged commit e0aad6f into knative:main Sep 9, 2021
@zroubalik zroubalik mentioned this pull request Sep 10, 2021
Merged
@lkingland lkingland deleted the runtimes-accessor branch September 20, 2022 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejvasek matejvasek matejvasek left review comments

@zroubalik zroubalik Awaiting requested review from zroubalik

@lance lance Awaiting requested review from lance

Assignees

@lance lance

@lkingland lkingland

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lkingland @knative-prow-robot @lance @matejvasek