Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish incrementals #255

Merged
merged 13 commits into from Sep 18, 2020
Merged

Publish incrementals #255

merged 13 commits into from Sep 18, 2020

Conversation

jglick
Copy link
Member

@jglick jglick commented Sep 17, 2020

No description provided.

@jglick jglick marked this pull request as draft September 17, 2020 21:32
@@ -26,6 +25,7 @@
<goal>shade</goal>
</goals>
<configuration>
<createDependencyReducedPom>false</createDependencyReducedPom>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to work around mojohaus/flatten-maven-plugin#100.

@@ -142,6 +139,7 @@ public void testWithUrl() throws Throwable {
}
}

@Ignore("TODO broken by https://github.com/jenkinsci/active-directory-plugin/releases/tag/active-directory-2.17; figure out how to pin a version")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use of Incrementals in jenkinsci/active-directory-plugin#102 seems to have broken these two tests. Anyway no tests here ought to be drawing plugin versions from the update center. (Perhaps we should simply remove this mode and only support -war? I do not know of anyone who actually uses it.)

@oleg-nenashev
Copy link
Member

We have an issue with Artifactory sponsorship costs, and I would recommend to avoid adding new Incrementals Pipelines until we resolve it. It is important especially for components with Dependabot which would generate a lot of deployments.

CC @MarkEWaite

@jglick
Copy link
Member Author

jglick commented Sep 18, 2020

@oleg-nenashev well this component is not producing that much compared to Jenkins core or the many incrementalified plugins, and I actually do need incremental versions of this for consumption from bom. Whatever issues we have with Artifactory (which have not yet even been identified), we can likely resolve them without loss of functionality.

Copy link

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will soon investigate ways to reduce the hosting costs that JFrog has been covering for the Jenkins project. I don't expect this addition will significantly change those costs. I recommend proceeding with it.

@jglick jglick merged commit 693d749 into jenkinsci:master Sep 18, 2020
@jglick jglick deleted the incrementals branch September 18, 2020 14:37
@jglick jglick mentioned this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants